Phuedx has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/158635

Change subject: Fix TaskRecommendationImpression offset for flyout
......................................................................

Fix TaskRecommendationImpression offset for flyout

Bug: 70358
Change-Id: Ide9cd83bd2b5d03f2fbc2d9b88c9333866eb887e
---
M resources/lightbulb/lightbulb.flyout.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted 
refs/changes/35/158635/1

diff --git a/resources/lightbulb/lightbulb.flyout.js 
b/resources/lightbulb/lightbulb.flyout.js
index ffd531e..c427551 100644
--- a/resources/lightbulb/lightbulb.flyout.js
+++ b/resources/lightbulb/lightbulb.flyout.js
@@ -151,7 +151,7 @@
                        userId: mwConfig.wgUserId,
                        pageId: mwConfig.wgArticleId,
                        'interface': 'flyout',
-                       offset: pageIndex
+                       offset: pageIndex * MAX_SUGGESTION_PER_PAGE_COUNT
                } );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/158635
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide9cd83bd2b5d03f2fbc2d9b88c9333866eb887e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Phuedx <g...@samsmith.io>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to