jenkins-bot has submitted this change and it was merged.
Change subject: mediawiki.notification: Also hide #mw-notification-area upon
creation
......................................................................
mediawiki.notification: Also hide #mw-notification-area upon creation
6c5b246 made it so #mw-notification-area was hidden when the last
notification was dismissed, but it still left it visible when
initially creating it. This meant that if you used mw.notify(),
you had no problems, but if you loaded the mediawiki.notification
module manually and called it manually, you would still get
a 12px-tall click-stealing invisible div until the first notification
was displayed.
Bug: 52659
Change-Id: Ibec399ac9ef083036aa2b31a38bcc1bc36b87d96
---
M resources/src/mediawiki/mediawiki.notification.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki/mediawiki.notification.js
b/resources/src/mediawiki/mediawiki.notification.js
index 79ec310..1968aa9 100644
--- a/resources/src/mediawiki/mediawiki.notification.js
+++ b/resources/src/mediawiki/mediawiki.notification.js
@@ -386,7 +386,8 @@
// on links from hiding a notification.
.on( 'click', 'a', function ( e ) {
e.stopPropagation();
- } );
+ } )
+ .hide();
// Prepend the notification area to the content area and save
it's object.
mw.util.$content.prepend( $area );
--
To view, visit https://gerrit.wikimedia.org/r/158659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibec399ac9ef083036aa2b31a38bcc1bc36b87d96
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Daniel Friesen <dan...@nadir-seen-fire.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
