jenkins-bot has submitted this change and it was merged.
Change subject: Add a testing mode to WikiGrok
......................................................................
Add a testing mode to WikiGrok
Also add an extra undefined check to avoid JS errors.
Change-Id: I15c78c8363889d93d068ad35ce92b8a0913f5ec9
---
M javascripts/modules/wikigrok/wikigrok.js
M javascripts/modules/wikigrok/wikigrokeval.js
2 files changed, 12 insertions(+), 4 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/wikigrok/wikigrok.js
b/javascripts/modules/wikigrok/wikigrok.js
index cb5168d..993dd1e 100644
--- a/javascripts/modules/wikigrok/wikigrok.js
+++ b/javascripts/modules/wikigrok/wikigrok.js
@@ -1,7 +1,16 @@
// Determine whether or not it is appropriate to load WikiGrok, and if so,
load it.
( function( M ) {
- var wikidataID = mw.config.get( 'wgWikibaseItemId' );
- //var wikidataID = 'Q508703';
+ var wikidataID = mw.config.get( 'wgWikibaseItemId' ),
+ idOverride;
+
+ // Allow query string override for testing, for example,
'?wikidataid=Q508703'
+ if ( !wikidataID ) {
+ idOverride = window.location.search.match( /wikidataid=([^&]*)/
);
+ if ( idOverride ) {
+ mw.config.set( 'wgWikibaseItemId', idOverride[1] );
+ wikidataID = idOverride[1];
+ }
+ }
// Only run in alpha mode
M.assertMode( [ 'alpha' ] );
diff --git a/javascripts/modules/wikigrok/wikigrokeval.js
b/javascripts/modules/wikigrok/wikigrokeval.js
index abfdb17..d5f5e99 100644
--- a/javascripts/modules/wikigrok/wikigrokeval.js
+++ b/javascripts/modules/wikigrok/wikigrokeval.js
@@ -1,6 +1,5 @@
( function( M, $ ) {
var wikidataID = mw.config.get( 'wgWikibaseItemId' );
- //var wikidataID = 'Q508703';
// Get existing Wikidata claims about this page so we can decide if
it's appropriate
// to display the WikiGrok interface.
@@ -24,7 +23,7 @@
WikiGrokDrawer;
// See if the page has any 'instance of' claims.
- if ( data.entities[wikidataID].claims.P31 !== undefined
) {
+ if ( data.entities !== undefined &&
data.entities[wikidataID].claims.P31 !== undefined ) {
instanceClaims =
data.entities[wikidataID].claims.P31;
$.each( instanceClaims, function( id, claim ) {
// See if any of the claims state that
the topic is a human.
--
To view, visit https://gerrit.wikimedia.org/r/158548
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15c78c8363889d93d068ad35ce92b8a0913f5ec9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
