Yaron Koren has submitted this change and it was merged. Change subject: Fix so that empty fields again won't show up in generated wikitext ......................................................................
Fix so that empty fields again won't show up in generated wikitext Change-Id: I3a5c798bb4681f2875cefdb1726eac40c53bab92 --- M includes/SF_FormPrinter.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaron Koren: Verified; Looks good to me, approved diff --git a/includes/SF_FormPrinter.php b/includes/SF_FormPrinter.php index e663d5a..cfb712f 100644 --- a/includes/SF_FormPrinter.php +++ b/includes/SF_FormPrinter.php @@ -1340,7 +1340,7 @@ $template_text .= "|$cur_value_in_template"; } else { // If the value is null, don't include it at all. - if ( $cur_value_in_template !== '' ) { + if ( $cur_value_in_template != '' ) { $template_text .= "\n|$field_name=$cur_value_in_template"; } } -- To view, visit https://gerrit.wikimedia.org/r/158995 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a5c798bb4681f2875cefdb1726eac40c53bab92 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticForms Gerrit-Branch: master Gerrit-Owner: Yaron Koren <yaro...@gmail.com> Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits