jenkins-bot has submitted this change and it was merged.
Change subject: Make help button for FieldLayout frameless again
......................................................................
Make help button for FieldLayout frameless again
It was working when I uploaded I30b9a5ce but then Id121fc3a got merged and
renamed the setting
(and reversed it, before my commit was merged)
Bug: 51798
Change-Id: I3835258ec933f74450af8501ae0d68c5ab1c5209
---
M src/layouts/FieldLayout.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/layouts/FieldLayout.js b/src/layouts/FieldLayout.js
index 2bb49fc..c02ca34 100644
--- a/src/layouts/FieldLayout.js
+++ b/src/layouts/FieldLayout.js
@@ -38,7 +38,7 @@
if ( config.help ) {
this.popupButtonWidget = new OO.ui.PopupButtonWidget( {
$: this.$,
- frameless: true,
+ framed: false,
icon: 'info',
title: config.help
} );
--
To view, visit https://gerrit.wikimedia.org/r/159095
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3835258ec933f74450af8501ae0d68c5ab1c5209
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits