Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/159104

Change subject: Provide contextual help for the page settings dialog's controls
......................................................................

Provide contextual help for the page settings dialog's controls

Bug: 51798
Change-Id: Ief3c52e504a08d255a8778af6e24785d35154898
---
M VisualEditor.php
M modules/ve-mw/i18n/en.json
M modules/ve-mw/i18n/qqq.json
M modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
4 files changed, 32 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/04/159104/1

diff --git a/VisualEditor.php b/VisualEditor.php
index 0cd968c..b49ba83 100644
--- a/VisualEditor.php
+++ b/VisualEditor.php
@@ -1020,6 +1020,7 @@
                        'visualeditor-dialog-meta-languages-section',
                        'visualeditor-dialog-meta-settings-displaytitle',
                        'visualeditor-dialog-meta-settings-displaytitle-enable',
+                       'visualeditor-dialog-meta-settings-hiddencat-help',
                        'visualeditor-dialog-meta-settings-hiddencat-label',
                        'visualeditor-dialog-meta-settings-index-default',
                        'visualeditor-dialog-meta-settings-index-disable',
@@ -1032,15 +1033,20 @@
                        
'visualeditor-dialog-meta-settings-newsectioneditlink-label',
                        
'visualeditor-dialog-meta-settings-nocontentconvert-label',
                        'visualeditor-dialog-meta-settings-nogallery-label',
+                       'visualeditor-dialog-meta-settings-noeditsection-help',
                        'visualeditor-dialog-meta-settings-noeditsection-label',
+                       'visualeditor-dialog-meta-settings-nogallery-help',
                        
'visualeditor-dialog-meta-settings-notitleconvert-label',
+                       'visualeditor-dialog-meta-settings-redirect-help',
                        'visualeditor-dialog-meta-settings-redirect-label',
                        
'visualeditor-dialog-meta-settings-redirect-placeholder',
+                       'visualeditor-dialog-meta-settings-redirect-statichelp',
                        
'visualeditor-dialog-meta-settings-redirect-staticlabel',
                        'visualeditor-dialog-meta-settings-section',
                        'visualeditor-dialog-meta-settings-toc-default',
                        'visualeditor-dialog-meta-settings-toc-disable',
                        'visualeditor-dialog-meta-settings-toc-force',
+                       'visualeditor-dialog-meta-settings-toc-help',
                        'visualeditor-dialog-meta-settings-toc-label',
                        'visualeditor-dialog-meta-title',
                        'visualeditor-dialogbutton-meta-tooltip',
diff --git a/modules/ve-mw/i18n/en.json b/modules/ve-mw/i18n/en.json
index 1f74d14..30d931c 100644
--- a/modules/ve-mw/i18n/en.json
+++ b/modules/ve-mw/i18n/en.json
@@ -92,6 +92,7 @@
     "visualeditor-dialog-meta-languages-section": "Languages",
     "visualeditor-dialog-meta-settings-displaytitle": "Display title",
     "visualeditor-dialog-meta-settings-displaytitle-enable": "Enable display 
title",
+    "visualeditor-dialog-meta-settings-hiddencat-help": "You can prevent this 
category from showing up in the list of categories on member pages. This is 
useful for categories that are of interest to editors but not most readers, 
like pages which need an illustration.",
     "visualeditor-dialog-meta-settings-hiddencat-label": "Hidden category",
     "visualeditor-dialog-meta-settings-index-default": "Default",
     "visualeditor-dialog-meta-settings-index-disable": "No",
@@ -103,16 +104,21 @@
     "visualeditor-dialog-meta-settings-newsectioneditlink-force": "Yes",
     "visualeditor-dialog-meta-settings-newsectioneditlink-label": "Show a tab 
on this page to add a new section",
     "visualeditor-dialog-meta-settings-nocontentconvert-label": "Don't convert 
content between language variants",
+    "visualeditor-dialog-meta-settings-noeditsection-help": "You can stop the 
edit links from appearing next to each section in the unusual case where that 
is appropriate.",
     "visualeditor-dialog-meta-settings-noeditsection-label": "Disable the edit 
links next to each heading on this page.",
+    "visualeditor-dialog-meta-settings-nogallery-help": "You can prevent this 
category from displaying member files as a gallery, if that is inappropriate in 
this case.",
     "visualeditor-dialog-meta-settings-nogallery-label": "Disable gallery",
     "visualeditor-dialog-meta-settings-notitleconvert-label": "Don't convert 
title between language variants",
+    "visualeditor-dialog-meta-settings-redirect-help": "You can make this page 
into a redirect, a page which will automatically take readers to another page 
on this wiki. This is useful for mis-spellings and alternative names or 
concepts. If you do so, readers will not see the contents of this page.",
     "visualeditor-dialog-meta-settings-redirect-label": "Redirect this page 
to",
     "visualeditor-dialog-meta-settings-redirect-placeholder": "Target page for 
redirection",
+    "visualeditor-dialog-meta-settings-redirect-statichelp": "You can prevent 
this redirect being updated automatically when the page to which it redirects 
is moved, in the very rare case that this is neeeded.",
     "visualeditor-dialog-meta-settings-redirect-staticlabel": "Prevent this 
redirect being updated when target page is moved.",
     "visualeditor-dialog-meta-settings-section": "Page settings",
     "visualeditor-dialog-meta-settings-toc-default": "If needed",
     "visualeditor-dialog-meta-settings-toc-disable": "Never",
     "visualeditor-dialog-meta-settings-toc-force": "Always",
+    "visualeditor-dialog-meta-settings-toc-help": "You can force a table of 
contents that lists each heading on the page to appear on pages with fewer than 
three headings, or force it to not appear at all. By default, it will appear if 
the page has three or more headings.",
     "visualeditor-dialog-meta-settings-toc-label": "Show the Table of 
Contents",
     "visualeditor-dialog-meta-title": "Options",
     "visualeditor-dialog-reference-options-group-label": "Use this group",
diff --git a/modules/ve-mw/i18n/qqq.json b/modules/ve-mw/i18n/qqq.json
index f829cbc..f765f95 100644
--- a/modules/ve-mw/i18n/qqq.json
+++ b/modules/ve-mw/i18n/qqq.json
@@ -101,6 +101,7 @@
        "visualeditor-dialog-meta-languages-section": "Label for the language 
links dialog section.\n{{Identical|Language}}",
        "visualeditor-dialog-meta-settings-displaytitle": "Label for the text 
box in which the user can set what the title of the page should be displayed 
as.",
        "visualeditor-dialog-meta-settings-displaytitle-enable": "Label for the 
checkbox to enable the use of the display title text box.",
+       "visualeditor-dialog-meta-settings-hiddencat-help": "Message displayed 
as contextual help about the <nowiki>__HIDDENCAT__</nowiki> tag to editors in 
the page settings panel on categories.",
        "visualeditor-dialog-meta-settings-hiddencat-label": "Prompt for the 
checkbox to let the user hide this category from pages.",
        "visualeditor-dialog-meta-settings-index-default": "Label for the 
option to have default indexing behavior.\n{{Identical|Default}}",
        "visualeditor-dialog-meta-settings-index-disable": "Label for the 
option for indexing to be forced off.\n{{Identical|No}}",
@@ -112,16 +113,21 @@
        "visualeditor-dialog-meta-settings-newsectioneditlink-force": "Label 
for the option to force the display of a new section creating 
link.\n{{Identical|Yes}}",
        "visualeditor-dialog-meta-settings-newsectioneditlink-label": "Prompt 
to let the user set the new section creating link behavior.\n\nFollowed by the 
following buttons:\n* 
{{msg-mw|Visualeditor-dialog-meta-settings-newsectioneditlink-force}}\n* 
{{msg-mw|Visualeditor-dialog-meta-settings-newsectioneditlink-default}}\n* 
{{msg-mw|Visualeditor-dialog-meta-settings-newsectioneditlink-disable}}",
        "visualeditor-dialog-meta-settings-nocontentconvert-label": "Prompt for 
the checkbox to let the user disable content conversion between language 
variants on the page.",
+       "visualeditor-dialog-meta-settings-noeditsection-help": "Message 
displayed as contextual help about the <nowiki>__NOEDITSECTION__</nowiki> tag 
to editors in the page settings panel.",
        "visualeditor-dialog-meta-settings-noeditsection-label": "Prompt for 
the checkbox to let the user disable section edit links on the page.",
+       "visualeditor-dialog-meta-settings-nogallery-help": "Message displayed 
as contextual help about the <nowiki>__NOGALLERY__</nowiki> tag to editors in 
the page settings panel on categories.",
        "visualeditor-dialog-meta-settings-nogallery-label": "Prompt for the 
checkbox to let the user disable gallery on the page.",
        "visualeditor-dialog-meta-settings-notitleconvert-label": "Prompt for 
the checkbox to let the user disable title conversion between language variants 
on the page.",
+       "visualeditor-dialog-meta-settings-redirect-help": "Message displayed 
as contextual help about redirects to editors in the page settings panel.",
        "visualeditor-dialog-meta-settings-redirect-label": "Label for the 
checkbox to let the user redirect the page.\n\nFollowed by input box which has 
the placeholder 
{{msg-mw|Visualeditor-dialog-meta-settings-redirect-placeholder}}.",
        "visualeditor-dialog-meta-settings-redirect-placeholder": "Placeholder 
for the target search box letting the user redirect the page.\n\nPreceded by 
the checkbox label 
{{msg-mw|Visualeditor-dialog-meta-settings-redirect-label}}.",
+       "visualeditor-dialog-meta-settings-redirect-statichelp": "Message 
displayed as contextual help about the <nowiki>__STATICREDIRECT__</nowiki> tag 
to editors in the page settings panel.",
        "visualeditor-dialog-meta-settings-redirect-staticlabel": "Label for 
the checkbox to let the user stop the redirect being updated on page 
moves.\n\nPreceded by \"Target page for redirection\" search box.",
        "visualeditor-dialog-meta-settings-section": "Label for the page 
settings dialog section.\n{{Identical|Page settings}}",
        "visualeditor-dialog-meta-settings-toc-default": "Label for the default 
TOC behavior option.\n{{Related|Visualeditor-dialog-meta-settings-toc}}",
        "visualeditor-dialog-meta-settings-toc-disable": "Label for the TOC 
behavior option to never 
show.\n{{Related|Visualeditor-dialog-meta-settings-toc}}",
        "visualeditor-dialog-meta-settings-toc-force": "Label for the TOC 
behavior option to always 
show.\n{{Related|Visualeditor-dialog-meta-settings-toc}}",
+       "visualeditor-dialog-meta-settings-toc-help": "Message displayed as 
contextual help about the <nowiki>__FORCETOC__</nowiki> and 
<nowiki>__NOTOC__</nowiki> tags to editors in the page settings panel.",
        "visualeditor-dialog-meta-settings-toc-label": "Prompt to let the user 
set the Table Of Contents (TOC) behaviour.",
        "visualeditor-dialog-meta-title": "Text of the title for the meta 
dialog to set categories, language links and other page 
settings.\n{{Identical|Options}}",
        "visualeditor-dialog-reference-options-group-label": "Label for the 
reference group input",
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
index 5fdd30a..8549ca9 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
@@ -57,7 +57,8 @@
                {
                        $: this.$,
                        align: 'top',
-                       label: ve.msg( 
'visualeditor-dialog-meta-settings-toc-label' )
+                       label: ve.msg( 
'visualeditor-dialog-meta-settings-toc-label' ),
+                       help: ve.msg( 
'visualeditor-dialog-meta-settings-toc-help' )
                }
        );
 
@@ -68,7 +69,8 @@
                {
                        $: this.$,
                        align: 'inline',
-                       label: ve.msg( 
'visualeditor-dialog-meta-settings-redirect-label' )
+                       label: ve.msg( 
'visualeditor-dialog-meta-settings-redirect-label' ),
+                       help: ve.msg( 
'visualeditor-dialog-meta-settings-redirect-help' )
                }
        );
        this.redirectTargetInput = new ve.ui.MWTitleInputWidget( {
@@ -88,7 +90,8 @@
                {
                        $: this.$,
                        align: 'inline',
-                       label: ve.msg( 
'visualeditor-dialog-meta-settings-redirect-staticlabel' )
+                       label: ve.msg( 
'visualeditor-dialog-meta-settings-redirect-staticlabel' ),
+                       help: ve.msg( 
'visualeditor-dialog-meta-settings-redirect-statichelp' )
                }
        );
        this.enableRedirectInput.connect( this, { change: 
'onEnableRedirectChange' } );
@@ -98,7 +101,8 @@
        this.metaItemCheckboxes = [
                {
                        metaName: 'mwNoEditSection',
-                       label: ve.msg( 
'visualeditor-dialog-meta-settings-noeditsection-label' )
+                       label: ve.msg( 
'visualeditor-dialog-meta-settings-noeditsection-label' ),
+                       help: ve.msg( 
'visualeditor-dialog-meta-settings-noeditsection-help' )
                }
        ].concat( ve.ui.MWSettingsPage.static.extraMetaCheckboxes );
 
@@ -106,11 +110,13 @@
                this.metaItemCheckboxes.push(
                        {
                                metaName: 'mwHiddenCategory',
-                               label: ve.msg( 
'visualeditor-dialog-meta-settings-hiddencat-label' )
+                               label: ve.msg( 
'visualeditor-dialog-meta-settings-hiddencat-label' ),
+                               help: ve.msg( 
'visualeditor-dialog-meta-settings-hiddencat-help' )
                        },
                        {
                                metaName: 'mwNoGallery',
-                               label: ve.msg( 
'visualeditor-dialog-meta-settings-nogallery-label' )
+                               label: ve.msg( 
'visualeditor-dialog-meta-settings-nogallery-label' ),
+                               help: ve.msg( 
'visualeditor-dialog-meta-settings-nogallery-help' )
                        }
                );
        }
@@ -128,7 +134,8 @@
                        {
                                $: settingsPage.$,
                                align: 'inline',
-                               label: this.label
+                               label: this.label,
+                               help: this.help || ''
                        }
                );
                settingsPage.settingsFieldset.addItems( [ this.fieldLayout ] );

-- 
To view, visit https://gerrit.wikimedia.org/r/159104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief3c52e504a08d255a8778af6e24785d35154898
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to