jenkins-bot has submitted this change and it was merged. Change subject: [FEAT] Add mandatory docstring tests ......................................................................
[FEAT] Add mandatory docstring tests Currently the docstring tests are not mandatory. Because with any change there is a chance that new PEP 257 errors are introduced it's hard to make them mandatory, because all errors need to be fixed at once. This change should make it easier as particular files can be fixed from PEP 257 errors and then added to the mandatory list. If now any later change introduces an error, it will fail the test on already fixed files. This adds only the test environment for tox but not actually adds the test, which needs to be done separately. All files which are PEP 257 compliant (except family files) are already added. Change-Id: I3e34ecc56996d58ace96299ceaf63a2278055fcb --- M tox.ini 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/tox.ini b/tox.ini index 3022ca6..ddecf62 100644 --- a/tox.ini +++ b/tox.ini @@ -23,6 +23,13 @@ # See upstream issue: # https://bitbucket.org/tarek/flake8/issue/167/flake8-223-stall-with-multiprocessing +[testenv:flake8-docstrings-mandatory] +# Add any new file which is pep257 compatible +commands = flake8 --jobs=1 --ignore=D102,D103,E122,E127,E241,E265 \ + ./pywikibot/echo.py ./pywikibot/config2.py ./pywikibot/weblib.py \ + ./pywikibot/fixes.py ./pywikibot/editor.py ./pywikibot/comms/http.py \ + ./pywikibot/compat/userlib.py ./pywikibot/compat/catlib.py +deps = flake8-docstrings [testenv:nose] setenv = PYWIKIBOT2_NO_USER_CONFIG=1 -- To view, visit https://gerrit.wikimedia.org/r/159073 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e34ecc56996d58ace96299ceaf63a2278055fcb Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise <[email protected]> Gerrit-Reviewer: John Vandenberg <[email protected]> Gerrit-Reviewer: Ladsgroup <[email protected]> Gerrit-Reviewer: Merlijn van Deen <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
