BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/159357

Change subject: Make renameuser_queue.rq_wiki nullable
......................................................................

Make renameuser_queue.rq_wiki nullable

This corrects an error in the original DDL for renameuser_queue
introduced in I61acceb. We intended the rq_wiki column to be nullable.
A null value will be used to indicate that the user requesting a rename
is already a global Central Auth account holder.

Change-Id: I342c6dcc19ded36ebab530e98a3d81a7dc188748
---
M central-auth.sql
A db_patches/patch-requestrename-fix-wiki.sql
2 files changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/57/159357/1

diff --git a/central-auth.sql b/central-auth.sql
index dfd73e9..f135bea 100644
--- a/central-auth.sql
+++ b/central-auth.sql
@@ -198,7 +198,8 @@
   rq_name varchar(255) binary not null,
 
   -- WikiID of home wiki for requesting user
-  rq_wiki varchar(255) binary not null,
+  -- Will be null if user is a CentralAuth account
+  rq_wiki varchar(255) binary,
 
   -- New name being requested
   rq_newname varchar(255) binary not null,
diff --git a/db_patches/patch-requestrename-fix-wiki.sql 
b/db_patches/patch-requestrename-fix-wiki.sql
new file mode 100644
index 0000000..0bc09a1
--- /dev/null
+++ b/db_patches/patch-requestrename-fix-wiki.sql
@@ -0,0 +1,4 @@
+-- Fix a problem in the original renameuser_queue patch.
+-- We intended renameuser_queue.rq_wiki to be nullable.
+ALTER TABLE renameuser_queue
+  CHANGE COLUMN rq_wiki rq_wiki varchar(255) binary;

-- 
To view, visit https://gerrit.wikimedia.org/r/159357
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I342c6dcc19ded36ebab530e98a3d81a7dc188748
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to