Mpaa has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/159394

Change subject: raise Error in TokenWallet if User has no rights
......................................................................

raise Error in TokenWallet if User has no rights

TokenWallet raises KeyError if user retrieves token for a not allowed
action.

Make the message more explicit:
Action 'patrol' is not allowed for user X on Y wiki.

Change-Id: Iac9567084dca017a1ac4ff07e4d0c994b51d79e5
---
M pywikibot/site.py
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/94/159394/1

diff --git a/pywikibot/site.py b/pywikibot/site.py
index 58a76bf..09d7293 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -1190,7 +1190,11 @@
         storage = self.site._tokens.setdefault(self.site.user(), {})
         if key not in storage:
             self.site.preload_tokens([key])
-        return storage[key]
+        try:
+            return storage[key]
+        except KeyError:
+            raise Error(u"Action '{0}' is not allowed for user {1} on {2} 
wiki."
+                        .format(key, self.site.user(), self.site))
 
 
 class APISite(BaseSite):

-- 
To view, visit https://gerrit.wikimedia.org/r/159394
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac9567084dca017a1ac4ff07e4d0c994b51d79e5
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to