EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/159507
Change subject: Hygiene: NoIndexExceptions are now expected
......................................................................
Hygiene: NoIndexExceptions are now expected
Initially all queries went through a cache, but we don't
want to maintain a cache for the various ways contributions
can be called. Instead of spamming the logs every time a contributions
query is wrong just remove the logging.
Change-Id: Idf86d203d63b11ccbf539ff1cd3caad2e54cc3d2
---
M includes/Data/ObjectLocator.php
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/07/159507/1
diff --git a/includes/Data/ObjectLocator.php b/includes/Data/ObjectLocator.php
index ce6974c..c2c7e5e 100644
--- a/includes/Data/ObjectLocator.php
+++ b/includes/Data/ObjectLocator.php
@@ -78,7 +78,7 @@
$index = $this->getIndexFor( $keys, $options );
$res = $index->findMulti( $queries, $options );
} catch ( NoIndexException $e ) {
- wfDebugLog( 'Flow', __METHOD__ . ': ' .
$e->getMessage() );
+ // fall back to direct storage query
$res = $this->storage->findMulti( $queries,
$this->convertToDbOptions( $options ) );
}
@@ -145,10 +145,8 @@
$res = $index->foundMulti( $queries, $options );
return $res;
} catch ( NoIndexException $e ) {
- wfDebugLog( 'Flow', __METHOD__ . ': ' .
$e->getMessage() );
+ return false;
}
-
- return false;
}
public function getPrimaryKeyColumns() {
--
To view, visit https://gerrit.wikimedia.org/r/159507
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf86d203d63b11ccbf539ff1cd3caad2e54cc3d2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
