Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/159544
Change subject: Remove $wgGoToEdit functionality ...................................................................... Remove $wgGoToEdit functionality SpecialSearchNogomatch can be used with a 1 liner to accomplish the same thing. In fact, there's an extension (BypassSearch) that already does this. Change-Id: I5d7e56ec6fe1110e29ac5c8ba5482b8fc2bf1956 --- M RELEASE-NOTES-1.24 M includes/DefaultSettings.php M includes/specials/SpecialSearch.php 3 files changed, 2 insertions(+), 13 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/44/159544/1 diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24 index 01ca4c1..925749d 100644 --- a/RELEASE-NOTES-1.24 +++ b/RELEASE-NOTES-1.24 @@ -68,6 +68,8 @@ * $wgCanonicalLanguageLinks has been removed. Per Google recommendations, we will not send a rel=canonical pointing to a variant-neutral page, however we will send rel=alternate. +* $wgGoToEdit has been removed. Use the SpecialSearchNogomatch hook for similar + functionality. === New features in 1.24 === * Added new hook WatchlistEditorBeforeFormRender, allowing subscribers to diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index 6626ab6..56c28e9 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -5588,11 +5588,6 @@ ); /** - * Go button goes straight to the edit screen if the article doesn't exist. - */ -$wgGoToEdit = false; - -/** * Enable the UniversalEditButton for browsers that support it * (currently only Firefox with an extension) * See http://universaleditbutton.org for more background information diff --git a/includes/specials/SpecialSearch.php b/includes/specials/SpecialSearch.php index 3407476..cca9ba9 100644 --- a/includes/specials/SpecialSearch.php +++ b/includes/specials/SpecialSearch.php @@ -197,14 +197,6 @@ $title = Title::newFromText( $term ); if ( !is_null( $title ) ) { wfRunHooks( 'SpecialSearchNogomatch', array( &$title ) ); - wfDebugLog( 'nogomatch', $title->getFullText(), 'private' ); - - # If the feature is enabled, go straight to the edit page - if ( $this->getConfig()->get( 'GoToEdit' ) ) { - $this->getOutput()->redirect( $title->getFullURL( array( 'action' => 'edit' ) ) ); - - return; - } } $this->showResults( $term ); } -- To view, visit https://gerrit.wikimedia.org/r/159544 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5d7e56ec6fe1110e29ac5c8ba5482b8fc2bf1956 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Chad <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
