Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/159552
Change subject: Kill use of super
......................................................................
Kill use of super
Change-Id: I37fa38b955104692ad544c71aaada9d48d209fcc
---
M javascripts/common/View.js
1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Mantle
refs/changes/52/159552/1
diff --git a/javascripts/common/View.js b/javascripts/common/View.js
index 3e112a1..db28167 100644
--- a/javascripts/common/View.js
+++ b/javascripts/common/View.js
@@ -67,8 +67,8 @@
* // {{>content}}
*
* var SomeView = View.extend( {
- * template: M.template.get( 'some' ),
- * templatePartials: { content: M.template.get( 'sub' ) }
+ * template: M.template.get( 'some.hogan' ),
+ * templatePartials: { content: M.template.get( 'sub.hogan'
) }
* }
*
* @type {Object}
@@ -83,13 +83,11 @@
defaults: {},
/**
- * Constructor, if you override it, use _super().
- *
* @method
* @param {Object} options Object passed to the constructor.
*/
initialize: function( options ) {
- this._super();
+ EventEmitter.prototype.initialize.apply( this,
arguments );
this.defaults = $.extend( {}, this._parent.defaults,
this.defaults );
this.templatePartials = $.extend( {},
this._parent.templatePartials, this.templatePartials );
options = $.extend( {}, this.defaults, options );
--
To view, visit https://gerrit.wikimedia.org/r/159552
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37fa38b955104692ad544c71aaada9d48d209fcc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Mantle
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
