Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/159808
Change subject: Rename frequency to pollInterval in SurfaceObserver
......................................................................
Rename frequency to pollInterval in SurfaceObserver
Frequency is measured in Hz/s^-1. What we are specifying is
a time interval.
Change-Id: I0a46b3f6880ea2f02b217610148e5dd8018bcc1f
---
M src/ce/ve.ce.SurfaceObserver.js
M tests/ce/ve.ce.TestRunner.js
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/08/159808/1
diff --git a/src/ce/ve.ce.SurfaceObserver.js b/src/ce/ve.ce.SurfaceObserver.js
index fc8df6b..deee9ed 100644
--- a/src/ce/ve.ce.SurfaceObserver.js
+++ b/src/ce/ve.ce.SurfaceObserver.js
@@ -23,7 +23,7 @@
this.domDocument = null;
this.polling = false;
this.timeoutId = null;
- this.frequency = 250; // ms
+ this.pollInterval = 250; // ms
// Initialization
this.clear();
@@ -113,10 +113,10 @@
this.pollOnce();
}
// only reach this point if pollOnce does not throw an exception
- if ( this.frequency !== null ) {
+ if ( this.pollInterval !== null ) {
this.timeoutId = this.setTimeout(
ve.bind( this.timerLoop, this ),
- this.frequency
+ this.pollInterval
);
}
};
diff --git a/tests/ce/ve.ce.TestRunner.js b/tests/ce/ve.ce.TestRunner.js
index 3f0a93c..5b0758d 100644
--- a/tests/ce/ve.ce.TestRunner.js
+++ b/tests/ce/ve.ce.TestRunner.js
@@ -124,7 +124,7 @@
this.postponedCalls = {};
// Turn off SurfaceObserver setTimeouts
- surface.view.surfaceObserver.frequency = null;
+ surface.view.surfaceObserver.pollInterval = null;
// Take control of eventSequencer 'setTimeouts'
testRunner = this;
--
To view, visit https://gerrit.wikimedia.org/r/159808
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a46b3f6880ea2f02b217610148e5dd8018bcc1f
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
