jenkins-bot has submitted this change and it was merged.
Change subject: Code quality: Remove jscs "requireSpacesInsideArrayBrackets"
over-ride and make pass
......................................................................
Code quality: Remove jscs "requireSpacesInsideArrayBrackets" over-ride and make
pass
Change-Id: I792a133efdb030eb8bd24ca455708107f1d623cc
---
M .jscsrc
M resources/mw.DestinationChecker.js
M resources/mw.UploadWizardUploadInterface.js
M tests/qunit/mw.UploadWizardLicenseInput.test.js
4 files changed, 6 insertions(+), 7 deletions(-)
Approvals:
Gilles: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.jscsrc b/.jscsrc
index 5045b01..8420099 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -3,6 +3,5 @@
"requireMultipleVarDecl": null,
"disallowDanglingUnderscores": null,
- "requireCamelCaseOrUpperCaseIdentifiers": null,
- "requireSpacesInsideArrayBrackets": null
-}
+ "requireCamelCaseOrUpperCaseIdentifiers": null
+ }
diff --git a/resources/mw.DestinationChecker.js
b/resources/mw.DestinationChecker.js
index 91ea26b..df89d4f 100644
--- a/resources/mw.DestinationChecker.js
+++ b/resources/mw.DestinationChecker.js
@@ -28,7 +28,7 @@
this.processResult = options.processResult;
this.api = options.api;
- $.each( ['preprocess', 'delay', 'events'], function ( i, option
) {
+ $.each( [ 'preprocess', 'delay', 'events' ], function ( i,
option ) {
if ( options[option] ) {
checker[option] = options[option];
}
diff --git a/resources/mw.UploadWizardUploadInterface.js
b/resources/mw.UploadWizardUploadInterface.js
index c41aaae..2867b7e 100644
--- a/resources/mw.UploadWizardUploadInterface.js
+++ b/resources/mw.UploadWizardUploadInterface.js
@@ -263,7 +263,7 @@
args = $.makeArray( info );
} else {
msgKey = 'api-error-unknown-code';
- args = [code].concat( $.makeArray( info ) );
+ args = [ code ].concat( $.makeArray( info ) );
}
this.setStatus( msgKey, args );
};
diff --git a/tests/qunit/mw.UploadWizardLicenseInput.test.js
b/tests/qunit/mw.UploadWizardLicenseInput.test.js
index 7926ad5..17d91c2 100644
--- a/tests/qunit/mw.UploadWizardLicenseInput.test.js
+++ b/tests/qunit/mw.UploadWizardLicenseInput.test.js
@@ -25,7 +25,7 @@
QUnit.test( 'createInputs()', 2, function ( assert ) {
var values,
- config = { type: 'or', licenses: ['cc-by-sa-3.0'] },
+ config = { type: 'or', licenses: [ 'cc-by-sa-3.0' ] },
uwLicenseInput;
uwLicenseInput = new mw.UploadWizardLicenseInput(
'#qunit-fixture', values, config );
@@ -45,7 +45,7 @@
{
head:
'mwe-upwiz-license-cc-head',
subhead:
'mwe-upwiz-license-cc-subhead',
- licenses: ['cc-by-sa-3.0']
+ licenses: [ 'cc-by-sa-3.0' ]
}
]
},
--
To view, visit https://gerrit.wikimedia.org/r/159953
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I792a133efdb030eb8bd24ca455708107f1d623cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
