jenkins-bot has submitted this change and it was merged.
Change subject: Fix SpecialPageFactory::getTitleForAlias
......................................................................
Fix SpecialPageFactory::getTitleForAlias
It takes the result of resolveAlias and calls SpecialPage::getTitleFor.
Unfortunately, resolveAlias returns an array of [name, subpage] while
getTitleFor expects two string arguments.
This commit makes SpecialPageFactory::getTitleForAlias call
SpecialPage::getTitleFor with two string arguments instead of an array.
Bug: 67045
Change-Id: Ia1a0abf753b03fc69d3d4de025c88312e3e45763
---
M includes/specialpage/SpecialPageFactory.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specialpage/SpecialPageFactory.php
b/includes/specialpage/SpecialPageFactory.php
index f3ad69c..0138cf9 100644
--- a/includes/specialpage/SpecialPageFactory.php
+++ b/includes/specialpage/SpecialPageFactory.php
@@ -609,9 +609,9 @@
* @return Title|null Title or null if there is no such alias
*/
static function getTitleForAlias( $alias ) {
- $name = self::resolveAlias( $alias );
- if ( $name ) {
- return SpecialPage::getTitleFor( $name );
+ list( $name, $subpage ) = self::resolveAlias( $alias );
+ if ( $name != null ) {
+ return SpecialPage::getTitleFor( $name, $subpage );
} else {
return null;
}
--
To view, visit https://gerrit.wikimedia.org/r/141845
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1a0abf753b03fc69d3d4de025c88312e3e45763
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: IAlex <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
