Chad has uploaded a new change for review.
https://gerrit.wikimedia.org/r/160057
Change subject: RawAction: private variable removing m prefix + doc better
......................................................................
RawAction: private variable removing m prefix + doc better
Change-Id: I526ebcbb1429af42fa9e33cdf59d12c4854247f7
---
M includes/actions/RawAction.php
1 file changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/57/160057/1
diff --git a/includes/actions/RawAction.php b/includes/actions/RawAction.php
index cd4e4ba..d0d956e 100644
--- a/includes/actions/RawAction.php
+++ b/includes/actions/RawAction.php
@@ -33,7 +33,13 @@
* @ingroup Actions
*/
class RawAction extends FormlessAction {
- private $mGen;
+ /**
+ * @var bool Does the request include a gen=css|javascript parameter
+ * @deprecated This used to be a string for "css" or "javascript" but
+ * it is no longer used. Setting this parameter results in empty content
+ * being served
+ */
+ private $gen = false;
public function getName() {
return 'raw';
@@ -66,12 +72,10 @@
$smaxage = $request->getIntOrNull( 'smaxage' );
if ( $gen == 'css' || $gen == 'js' ) {
- $this->mGen = $gen;
+ $this->gen = true;
if ( $smaxage === null ) {
$smaxage = $config->get( 'SquidMaxage' );
}
- } else {
- $this->mGen = false;
}
$contentType = $this->getContentType();
@@ -130,7 +134,7 @@
global $wgParser;
# No longer used
- if ( $this->mGen ) {
+ if ( $this->gen ) {
return '';
}
--
To view, visit https://gerrit.wikimedia.org/r/160057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I526ebcbb1429af42fa9e33cdf59d12c4854247f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
