jenkins-bot has submitted this change and it was merged. Change subject: Grant all gadgets-*** userrights to sysop group by default ......................................................................
Grant all gadgets-*** userrights to sysop group by default Extensions should use a sane default configuration, and it is expected that sysops will be able to create/edit gadgets. This is also needed for backwards-compatability from Gadgets 1.0. Change-Id: I377e9e9a6477a337baf031b4e802ca58586f6392 See: https://www.mediawiki.org/wiki/Thread:Talk:ResourceLoader/Version_2_Design_Specification/Task_management/NS_GADGET_editing --- M Gadgets.php 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Jackmcbarn: Looks good to me, but someone else must approve Alex Monk: Looks good to me, approved Helder.wiki: Looks good to me, but someone else must approve jenkins-bot: Verified Objections: Krinkle: There's a problem with this change, please improve diff --git a/Gadgets.php b/Gadgets.php index aa02f7a..eefd866 100644 --- a/Gadgets.php +++ b/Gadgets.php @@ -88,13 +88,11 @@ 'gadgets-definition-delete' ) ); -// Example of user groups -// Copy to your LocalSettings.php to use these -// or grant the rights to an existing group (e.g. sysops) -#$wgGroupPermissions['gadgetartists']['gadgets-edit'] = true; -#$wgGroupPermissions['gadgetmanagers']['gadgets-definition-create'] = true; -#$wgGroupPermissions['gadgetmanagers']['gadgets-definition-edit'] = true; -#$wgGroupPermissions['gadgetmanagers']['gadgets-definition-delete'] = true; +// Give all gadgets-* userrights to sysops by default +$wgGroupPermissions['sysop']['gadgets-edit'] = true; +$wgGroupPermissions['sysop']['gadgets-definition-create'] = true; +$wgGroupPermissions['sysop']['gadgets-definition-edit'] = true; +$wgGroupPermissions['sysop']['gadgets-definition-delete'] = true; $wgHooks['AfterImportPage'][] = 'GadgetsHooks::gadgetDefinitionImport'; $wgHooks['AfterImportPage'][] = 'GadgetsHooks::cssOrJsPageImport'; -- To view, visit https://gerrit.wikimedia.org/r/155745 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I377e9e9a6477a337baf031b4e802ca58586f6392 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Gadgets Gerrit-Branch: RL2 Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Alex Monk <kren...@wikimedia.org> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: Helder.wiki <helder.w...@gmail.com> Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Nemo bis <federicol...@tiscali.it> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
