jenkins-bot has submitted this change and it was merged.
Change subject: Code quality: Remove jscs
"requireCamelCaseOrUpperCaseIdentifiers" over-ride and make pass
......................................................................
Code quality: Remove jscs "requireCamelCaseOrUpperCaseIdentifiers" over-ride
and make pass
Actually, this last one is a bit of a lie due to Flickr's variable names, but…
completion!
Change-Id: Idad4e8ec2c98cd5bb7865d306a1b2ae132c62455
---
M .jscsrc
M resources/mw.FlickrChecker.js
M resources/mw.UploadWizardUpload.js
3 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Gilles: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.jscsrc b/.jscsrc
index 1bf3308..9d22e3f 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -1,5 +1,3 @@
{
- "preset": "wikimedia",
-
- "requireCamelCaseOrUpperCaseIdentifiers": null
+ "preset": "wikimedia"
}
diff --git a/resources/mw.FlickrChecker.js b/resources/mw.FlickrChecker.js
index 5e6e82d..5fe35df 100644
--- a/resources/mw.FlickrChecker.js
+++ b/resources/mw.FlickrChecker.js
@@ -1,6 +1,6 @@
// Only turning these jshint options off for ''this file''
/* jshint camelcase: false, nomen: false */
-/* jscs:disable disallowDanglingUnderscores */
+/* jscs:disable disallowDanglingUnderscores,
requireCamelCaseOrUpperCaseIdentifiers */
( function ( mw, $ ) {
mw.FlickrChecker = function ( wizard, upload ) {
this.wizard = wizard;
diff --git a/resources/mw.UploadWizardUpload.js
b/resources/mw.UploadWizardUpload.js
index 10de8b4..5da5b1f 100644
--- a/resources/mw.UploadWizardUpload.js
+++ b/resources/mw.UploadWizardUpload.js
@@ -6,7 +6,7 @@
* should fork this into two -- local and remote, e.g. filename
*/
/* jshint camelcase: false, nomen: false */
-/* jscs:disable disallowDanglingUnderscores */
+/* jscs:disable disallowDanglingUnderscores,
requireCamelCaseOrUpperCaseIdentifiers */
( function ( mw, $, oo ) {
var UWUP,
--
To view, visit https://gerrit.wikimedia.org/r/159956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idad4e8ec2c98cd5bb7865d306a1b2ae132c62455
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
