jenkins-bot has submitted this change and it was merged.
Change subject: Check whether there is a range selected when enabling/disabling
re-use citation tool
......................................................................
Check whether there is a range selected when enabling/disabling re-use citation
tool
If there is no range selected, disable regardless of whether there are
references in the document or not.
Bug: 70870
Change-Id: I2c281fefe7915345fafb735b3788166ab8118049
---
M modules/ve-mw/ui/tools/ve.ui.MWReferenceDialogTool.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/tools/ve.ui.MWReferenceDialogTool.js
b/modules/ve-mw/ui/tools/ve.ui.MWReferenceDialogTool.js
index 6f0fe50..a4fc6ec 100644
--- a/modules/ve-mw/ui/tools/ve.ui.MWReferenceDialogTool.js
+++ b/modules/ve-mw/ui/tools/ve.ui.MWReferenceDialogTool.js
@@ -70,7 +70,7 @@
return false;
}
} );
- this.setDisabled( empty );
+ this.setDisabled( ( this.constructor.static.requiresRange &&
!fragment.getRange() ) || empty );
};
ve.ui.toolFactory.register( ve.ui.MWUseExistingReferenceDialogTool );
--
To view, visit https://gerrit.wikimedia.org/r/160556
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c281fefe7915345fafb735b3788166ab8118049
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
