jenkins-bot has submitted this change and it was merged. Change subject: Made SiteSQLStore use startAtomic() instead of DIY ......................................................................
Made SiteSQLStore use startAtomic() instead of DIY Change-Id: I3f47675646d772b4718086e2715e243da3a16bab --- M includes/site/SiteSQLStore.php 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Reedy: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/site/SiteSQLStore.php b/includes/site/SiteSQLStore.php index 6659407..944e9e2 100644 --- a/includes/site/SiteSQLStore.php +++ b/includes/site/SiteSQLStore.php @@ -314,11 +314,7 @@ $dbw = $this->sitesTable->getWriteDbConnection(); - $trx = $dbw->trxLevel(); - - if ( $trx == 0 ) { - $dbw->begin( __METHOD__ ); - } + $dbw->startAtomic( __METHOD__ ); $success = true; @@ -360,9 +356,7 @@ ); } - if ( $trx == 0 ) { - $dbw->commit( __METHOD__ ); - } + $dbw->endAtomic( __METHOD__ ); // purge cache $this->reset(); -- To view, visit https://gerrit.wikimedia.org/r/160153 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f47675646d772b4718086e2715e243da3a16bab Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org> Gerrit-Reviewer: Reedy <re...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits