jenkins-bot has submitted this change and it was merged. Change subject: Fix garbled dropdown text ......................................................................
Fix garbled dropdown text Bug: 70918 Change-Id: I84683ef373409c808ccfaa3b0c3aafef813349b7 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/897 (cherry picked from commit 57b2799081a2d7e01fad902502a71a9f895d8530) --- M resources/mmv/ui/mmv.ui.reuse.download.js M resources/mmv/ui/mmv.ui.reuse.embed.js 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Gergő Tisza: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/mmv/ui/mmv.ui.reuse.download.js b/resources/mmv/ui/mmv.ui.reuse.download.js index 805957b..4b11014 100644 --- a/resources/mmv/ui/mmv.ui.reuse.download.js +++ b/resources/mmv/ui/mmv.ui.reuse.download.js @@ -109,9 +109,9 @@ 'original' ); - this.downloadSizeMenu.onMenuSelect = function( item ) { + this.downloadSizeMenu.on( 'select', function( item ) { mw.mmv.actionLogger.log( 'download-select-menu-' + item.data.name ); - }; + } ); $container.append( this.downloadSizeMenu.$element ); }; diff --git a/resources/mmv/ui/mmv.ui.reuse.embed.js b/resources/mmv/ui/mmv.ui.reuse.embed.js index 00d8707..77f5b89 100644 --- a/resources/mmv/ui/mmv.ui.reuse.embed.js +++ b/resources/mmv/ui/mmv.ui.reuse.embed.js @@ -196,9 +196,9 @@ 'default' ); - this.embedSizeSwitchWikitext.onMenuSelect = function( item ) { + this.embedSizeSwitchWikitext.on( 'select', function( item ) { mw.mmv.actionLogger.log( 'embed-select-menu-wikitext-' + item.data.name ); - }; + } ); // Html sizes pulldown menu this.embedSizeSwitchHtml = this.utils.createPulldownMenu( @@ -207,9 +207,9 @@ 'original' ); - this.embedSizeSwitchHtml.onMenuSelect = function( item ) { + this.embedSizeSwitchHtml.on( 'select', function( item ) { mw.mmv.actionLogger.log( 'embed-select-menu-html-' + item.data.name ); - }; + } ); $( '<p>' ) .append( -- To view, visit https://gerrit.wikimedia.org/r/161109 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84683ef373409c808ccfaa3b0c3aafef813349b7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: wmf/1.24wmf20 Gerrit-Owner: Gergő Tisza <[email protected]> Gerrit-Reviewer: Gergő Tisza <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
