jenkins-bot has submitted this change and it was merged. Change subject: Fix patch which fixes the reuse dropdowns ......................................................................
Fix patch which fixes the reuse dropdowns See https://bugzilla.wikimedia.org/show_bug.cgi?id=70968 for explanation. Bug: 70918 Change-Id: Ibe1c4c1e415952982049d7c581253bb5b8a2e500 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/897 --- M resources/mmv/ui/mmv.ui.reuse.download.js M resources/mmv/ui/mmv.ui.reuse.embed.js 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: MarkTraceur: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/mmv/ui/mmv.ui.reuse.download.js b/resources/mmv/ui/mmv.ui.reuse.download.js index 4b11014..6f108af 100644 --- a/resources/mmv/ui/mmv.ui.reuse.download.js +++ b/resources/mmv/ui/mmv.ui.reuse.download.js @@ -109,7 +109,7 @@ 'original' ); - this.downloadSizeMenu.on( 'select', function( item ) { + this.downloadSizeMenu.getMenu().on( 'select', function( item ) { mw.mmv.actionLogger.log( 'download-select-menu-' + item.data.name ); } ); diff --git a/resources/mmv/ui/mmv.ui.reuse.embed.js b/resources/mmv/ui/mmv.ui.reuse.embed.js index 77f5b89..d41b6ad 100644 --- a/resources/mmv/ui/mmv.ui.reuse.embed.js +++ b/resources/mmv/ui/mmv.ui.reuse.embed.js @@ -196,7 +196,7 @@ 'default' ); - this.embedSizeSwitchWikitext.on( 'select', function( item ) { + this.embedSizeSwitchWikitext.getMenu().on( 'select', function( item ) { mw.mmv.actionLogger.log( 'embed-select-menu-wikitext-' + item.data.name ); } ); @@ -207,7 +207,7 @@ 'original' ); - this.embedSizeSwitchHtml.on( 'select', function( item ) { + this.embedSizeSwitchHtml.getMenu().on( 'select', function( item ) { mw.mmv.actionLogger.log( 'embed-select-menu-html-' + item.data.name ); } ); -- To view, visit https://gerrit.wikimedia.org/r/161112 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe1c4c1e415952982049d7c581253bb5b8a2e500 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Gergő Tisza <[email protected]> Gerrit-Reviewer: MarkTraceur <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
