jenkins-bot has submitted this change and it was merged.
Change subject: Add tests for api xml format
......................................................................
Add tests for api xml format
Tests for wbgetclaims and wbgetentities xml format
Change-Id: Icb29307d44c79059e59c7e0fc275d2abb5fc0ecd
---
A repo/tests/phpunit/data/api/getclaims.xml
A repo/tests/phpunit/data/api/getentities.xml
A repo/tests/phpunit/includes/api/ApiXmlFormatTest.php
3 files changed, 194 insertions(+), 0 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/tests/phpunit/data/api/getclaims.xml
b/repo/tests/phpunit/data/api/getclaims.xml
new file mode 100644
index 0000000..8a0c7e4
--- /dev/null
+++ b/repo/tests/phpunit/data/api/getclaims.xml
@@ -0,0 +1 @@
+<?xml version="1.0"?><api><claims><claim id="P1491009"><claim
id="Q80050245$kittens" type="statement" rank="normal"><mainsnak
snaktype="novalue" property="P1491009" /><qualifiers /><qualifiers-order
/></claim></claim><claim>property</claim></claims></api>
diff --git a/repo/tests/phpunit/data/api/getentities.xml
b/repo/tests/phpunit/data/api/getentities.xml
new file mode 100644
index 0000000..5f6ceb6
--- /dev/null
+++ b/repo/tests/phpunit/data/api/getentities.xml
@@ -0,0 +1 @@
+<?xml version="1.0"?><api success="1"><entities><entity pageid="2276" ns="0"
title="Q80050245" lastrevid="4089" modified="2014-09-07T20:39:03Z"
id="Q80050245" type="item"><aliases /><labels /><descriptions
/><claims><property id="P1491009"><claim id="Q80050245$kittens"
type="statement" rank="normal"><mainsnak snaktype="novalue" property="P1491009"
/><qualifiers /><qualifiers-order /></claim></property></claims><sitelinks
/></entity></entities></api>
diff --git a/repo/tests/phpunit/includes/api/ApiXmlFormatTest.php
b/repo/tests/phpunit/includes/api/ApiXmlFormatTest.php
new file mode 100644
index 0000000..c70dab5
--- /dev/null
+++ b/repo/tests/phpunit/includes/api/ApiXmlFormatTest.php
@@ -0,0 +1,192 @@
+<?php
+
+namespace Wikibase\Test\Api;
+
+use ApiBase;
+use ApiMain;
+use Exception;
+use FauxRequest;
+use Wikibase\DataModel\ByPropertyIdArray;
+use Wikibase\DataModel\Claim\Statement;
+use Wikibase\DataModel\Entity\Item;
+use Wikibase\DataModel\Entity\Property;
+use Wikibase\DataModel\Snak\PropertyNoValueSnak;
+use Wikibase\EntityRevision;
+use Wikibase\Repo\WikibaseRepo;
+
+/**
+ * @fixme wbgetclaims adds an extra <claim>property</claim> in output! see bug
70531
+ *
+ * @group API
+ * @group Wikibase
+ * @group WikibaseAPI
+ * @group WikibaseRepo
+ * @group medium
+ *
+ * @licence GNU GPL v2+
+ * @author Katie Filbert < aude.w...@gmail.com >
+ */
+class ApiXmlFormatTest extends \PHPUnit_Framework_TestCase {
+
+ /**
+ * @var EntityRevision
+ */
+ private $entityRevision;
+
+ public function testGetEntitiesXmlFormat() {
+ $entityRevision = $this->getEntityRevision();
+ $entityId =
$entityRevision->getEntity()->getId()->getSerialization();
+
+ $params = array(
+ 'action' => 'wbgetentities',
+ 'ids' => $entityId
+ );
+
+ $module = $this->getApiModule( '\Wikibase\Api\GetEntities',
'wbgetentities', $params );
+ $result = $this->doApiRequest( $module );
+ $actual = $this->removeGetEntitiesAttributes( $result,
$entityId );
+
+ $expected = $this->getExpectedGetEntitiesXml( $entityRevision );
+
+ $this->assertEquals( $expected, $actual );
+ }
+
+ private function getExpectedGetEntitiesXml( EntityRevision
$entityRevision ) {
+ $xml = trim( file_get_contents( __DIR__ .
'/../../data/api/getentities.xml' ) );
+
+ $expected = $this->replaceIdsInExpectedXml( $xml,
$entityRevision );
+ $expected = $this->removeGetEntitiesAttributes(
+ $expected,
+
$entityRevision->getEntity()->getId()->getSerialization()
+ );
+
+ return $expected;
+ }
+
+ private function replaceIdsInExpectedXml( $xml, EntityRevision
$entityRevision ) {
+ $xml = $this->replacePropertyId( $xml, $entityRevision );
+ $xml = $this->replaceEntityId(
+ $xml,
+
$entityRevision->getEntity()->getId()->getSerialization()
+ );
+
+ return $xml;
+ }
+
+ private function replaceEntityId( $xml, $entityId ) {
+ return str_replace( 'Q80050245', $entityId, $xml );
+ }
+
+ private function replacePropertyId( $xml, EntityRevision
$entityRevision ) {
+ $claims = $entityRevision->getEntity()->getClaims();
+
+ $byPropertyIdArray = new ByPropertyIdArray( $claims );
+ $byPropertyIdArray->buildIndex();
+
+ $propertyIds = $byPropertyIdArray->getPropertyIds();
+
+ foreach( $propertyIds as $propertyId ) {
+ $propertyIdText = $propertyId->getSerialization();
+ }
+
+ return str_replace( 'P1491009', $propertyIdText, $xml );
+ }
+
+ private function removeGetEntitiesAttributes( $xml, $entityId ) {
+ $dom = new \DOMDocument( '1.0', 'UTF-8' );
+ $dom->loadXML( $xml );
+
+ $xpath = new \DOMXPath( $dom );
+ $element = $xpath->query( "//*[@id='$entityId']" )->item( 0 );
+
+ $attributesToRemove = array( 'pageid', 'lastrevid', 'modified',
'title', 'ns' );
+
+ foreach( $attributesToRemove as $attributeToRemove ) {
+ $element->removeAttribute( $attributeToRemove );
+ }
+
+ return $dom->saveXML();
+ }
+
+ public function testGetClaimsXmlFormat() {
+ $entityRevision = $this->getEntityRevision();
+ $entityId =
$entityRevision->getEntity()->getId()->getSerialization();
+
+ $params = array(
+ 'action' => 'wbgetclaims',
+ 'entity' => $entityId
+ );
+
+ $module = $this->getApiModule( '\Wikibase\Api\GetClaims',
'wbgetclaims', $params );
+ $actual = $this->doApiRequest( $module );
+ $expected = $this->getExpectedGetClaimsXml( $entityRevision );
+
+ $this->assertEquals( $expected, $actual );
+ }
+
+ private function getExpectedGetClaimsXml( EntityRevision
$entityRevision ) {
+ $xml = trim( file_get_contents( __DIR__ .
'/../../data/api/getclaims.xml' ) );
+
+ return $this->replaceIdsInExpectedXml( $xml, $entityRevision );
+ }
+
+ private function getApiModule( $moduleClass, $moduleName, array $params
) {
+ $request = new FauxRequest( $params, true );
+ $main = new ApiMain( $request );
+
+ return new $moduleClass( $main, $moduleName );
+ }
+
+ private function doApiRequest( ApiBase $module ) {
+ $printer = $module->getMain()->createPrinterByName( 'xml' );
+ $module->getResult()->setRawMode( $printer->getNeedsRawData() );
+ $module->execute();
+
+ $printer->setUnescapeAmps( false );
+ $printer->initPrinter( false );
+
+ ob_start();
+
+ try {
+ $printer->execute();
+ $output = ob_get_clean();
+ } catch ( Exception $ex ) {
+ ob_end_clean();
+ throw $ex;
+ }
+
+ $printer->closePrinter();
+
+ return $output;
+ }
+
+ private function getEntityRevision() {
+ if ( !isset( $this->entityRevision ) ) {
+ $this->entityRevision = $this->addClaim();
+ }
+
+ return $this->entityRevision;
+ }
+
+ private function addClaim() {
+ $store = WikibaseRepo::getDefaultInstance()->getEntityStore();
+
+ $property = Property::newFromType( 'string' );
+ $entityRevision = $store->saveEntity( $property, 'testing',
$GLOBALS['wgUser'], EDIT_NEW );
+ $propertyId = $entityRevision->getEntity()->getId();
+
+ $item = Item::newEmpty();
+ $entityRevision = $store->saveEntity( $item, 'testing',
$GLOBALS['wgUser'], EDIT_NEW );
+ $item = $entityRevision->getEntity();
+
+ $snak = new PropertyNoValueSnak( $propertyId->getNumericId() );
+ $statement = new Statement( $snak );
+
+ $statement->setGuid( $item->getId()->getSerialization() .
'$kittens' );
+ $item->addClaim( $statement );
+ $entityRevision = $store->saveEntity( $item, 'testing more!',
$GLOBALS['wgUser'] );
+
+ return $entityRevision;
+ }
+
+}
--
To view, visit https://gerrit.wikimedia.org/r/161213
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb29307d44c79059e59c7e0fc275d2abb5fc0ecd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.24-wmf19
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
