jenkins-bot has submitted this change and it was merged. Change subject: Improve styleability of RecentChanges form ......................................................................
Improve styleability of RecentChanges form The current form is a sequence of text and links without any structure which makes it impossible to apply styles. This patch wraps some elements in spans and assigns class names, so that they can be targeted by CSS rules. Change-Id: If3ca99b0bd251528ced856822c8e52a18657deb8 --- M includes/specials/SpecialRecentchanges.php 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Aude: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php index 5938f01..25da16d 100644 --- a/includes/specials/SpecialRecentchanges.php +++ b/includes/specials/SpecialRecentchanges.php @@ -732,7 +732,7 @@ $link = $this->makeOptionsLink( $linkMessage->text(), array( $key => 1 - $options[$key] ), $nondefaults ); - $links[] = $this->msg( $msg )->rawParams( $link )->escaped(); + $links[] = "<span class=\"$msg rcshowhideoption\">" . $this->msg( $msg )->rawParams( $link )->escaped() . '</span>'; } // show from this onward link @@ -740,13 +740,16 @@ $now = $lang->userTimeAndDate( $timestamp, $user ); $timenow = $lang->userTime( $timestamp, $user ); $datenow = $lang->userDate( $timestamp, $user ); - $rclinks = $this->msg( 'rclinks' )->rawParams( $cl, $dl, $lang->pipeList( $links ) ) - ->parse(); - $rclistfrom = $this->makeOptionsLink( + $pipedLinks = '<span class="rcshowhide">' . $lang->pipeList( $links ) . '</span>'; + + $rclinks = '<span class="rclinks">' . $this->msg( 'rclinks' )->rawParams( $cl, $dl, $pipedLinks ) + ->parse() . '</span>'; + + $rclistfrom = '<span class="rclistfrom">' . $this->makeOptionsLink( $this->msg( 'rclistfrom' )->rawParams( $now, $timenow, $datenow )->parse(), array( 'from' => $timestamp ), $nondefaults - ); + ) . '</span>'; return "{$note}$rclinks<br />$rclistfrom"; } -- To view, visit https://gerrit.wikimedia.org/r/160288 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3ca99b0bd251528ced856822c8e52a18657deb8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Foxtrott <s7ep...@gmail.com> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Bartosz DziewoĆski <matma....@gmail.com> Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits