Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/161346
Change subject: Remove test for functionality tested in core
......................................................................
Remove test for functionality tested in core
Add comment to remaining test explaning its purpose.
Depends on Id7c291b in core.
Change-Id: Ia545edac3b2adbd6d45ed5427a9e5e6f9df0da54
---
M modules/ve-mw/tests/ce/ve.ce.Surface.test.js
1 file changed, 2 insertions(+), 35 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/46/161346/1
diff --git a/modules/ve-mw/tests/ce/ve.ce.Surface.test.js
b/modules/ve-mw/tests/ce/ve.ce.Surface.test.js
index cce095e..9eebc58 100644
--- a/modules/ve-mw/tests/ce/ve.ce.Surface.test.js
+++ b/modules/ve-mw/tests/ce/ve.ce.Surface.test.js
@@ -12,41 +12,8 @@
QUnit.test( 'handleDelete', function ( assert ) {
var i,
cases = [
- {
- html:
- '<p>Foo</p>' +
-
ve.dm.mwExample.MWTransclusion.blockOpen +
ve.dm.mwExample.MWTransclusion.blockContent +
- '<p>Bar</p>',
- range: new ve.Range( 4 ),
- operations: ['delete'],
- expectedData: function () {},
- expectedRange: new ve.Range( 5, 7 ),
- msg: 'Block transclusion is focused not deleted'
- },
- {
- html:
- '<p>Foo</p>' +
-
ve.dm.mwExample.MWTransclusion.blockOpen +
ve.dm.mwExample.MWTransclusion.blockContent +
- '<p>Bar</p>',
- range: new ve.Range( 4 ),
- operations: ['delete', 'delete'],
- expectedData: function ( data ) {
- data.splice( 5, 2 );
- },
- expectedRange: new ve.Range( 6 ),
- msg: 'Block transclusion is deleted with two
keypresses'
- },
- {
- html:
- '<p>Foo</p>' +
- ve.dm.mwExample.MWBlockImage.html +
- '<p>Bar</p>',
- range: new ve.Range( 4 ),
- operations: ['delete'],
- expectedData: function () { },
- expectedRange: new ve.Range( 5, 14 ),
- msg: 'Block image is focused not deleted'
- },
+ // This asserts that getRelativeRange (via
getRelativeOffset) doesn't try to
+ // enter a handleOwnChildren node
{
html:
ve.dm.mwExample.MWBlockImage.html +
--
To view, visit https://gerrit.wikimedia.org/r/161346
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia545edac3b2adbd6d45ed5427a9e5e6f9df0da54
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
