jenkins-bot has submitted this change and it was merged.
Change subject: checkbox.less: Set cursor on label instead of pseudo element
......................................................................
checkbox.less: Set cursor on label instead of pseudo element
Bug: 70474
Change-Id: I4b8edd987b724241f748d7891991f0cd7dc80b1b
---
M resources/src/mediawiki.ui/components/checkbox.less
1 file changed, 8 insertions(+), 3 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.ui/components/checkbox.less
b/resources/src/mediawiki.ui/components/checkbox.less
index 6d6fdde..f7f7460 100644
--- a/resources/src/mediawiki.ui/components/checkbox.less
+++ b/resources/src/mediawiki.ui/components/checkbox.less
@@ -44,6 +44,8 @@
// the pseudo before element of the label after the checkbox
now looks like a checkbox
& + label {
+ cursor: pointer;
+
&::before {
content: '';
position: absolute;
@@ -54,7 +56,6 @@
width: @checkboxSize;
height: @checkboxSize;
background-color: #fff;
- cursor: pointer;
border: 1px solid grey;
}
}
@@ -87,8 +88,12 @@
}
// disabled checked boxes have a gray background
- &:disabled + label::before {
- background-color: lightgrey;
+ &:disabled + label {
+ cursor: default;
+
+ &::before {
+ background-color: lightgrey;
+ }
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/161280
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b8edd987b724241f748d7891991f0cd7dc80b1b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
