jenkins-bot has submitted this change and it was merged.
Change subject: Tighter query for images.
......................................................................
Tighter query for images.
Use a more-precise selector query for <img> tags within figures, better
matching the Parsoid DOM spec.
Change-Id: I7d42eaa8ec02d4a1066e9344a18f2263e2efbfd4
---
M lib/parsoid.js
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Cscott: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/parsoid.js b/lib/parsoid.js
index a75baf5..1259e54 100644
--- a/lib/parsoid.js
+++ b/lib/parsoid.js
@@ -66,9 +66,9 @@
ParsoidResult.prototype.getImages = function() {
var base = this.getBaseHref();
var imgs = this.document.querySelectorAll([
- 'figure img[resource]',
- '*[typeof="mw:Image"] img[resource]',
- '*[typeof="mw:Image/Thumb"] img[resource]'
+ 'figure > * > img[resource]',
+ '*[typeof="mw:Image"] > * > img[resource]',
+ '*[typeof="mw:Image/Thumb"] > * > img[resource]'
].join(','));
return Array.prototype.map.call(imgs, function(img) {
var relResourceURL =
decodeURIComponent(img.getAttribute('resource'));
--
To view, visit https://gerrit.wikimedia.org/r/152085
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d42eaa8ec02d4a1066e9344a18f2263e2efbfd4
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Collection/OfflineContentGenerator/bundler
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
