Spage has uploaded a new change for review.
https://gerrit.wikimedia.org/r/161411
Change subject: QA: fix Topic collapsing for new modal dialog
......................................................................
QA: fix Topic collapsing for new modal dialog
Topic collapsing.Small topics view fails hiding a post, because we have
a new modal dialog.
Change-Id: I3a3e8db8246bb40af8e83bbafc6dc8d9120cecef
---
M tests/browser/features/step_definitions/moderation_steps.rb
M tests/browser/features/support/pages/flow_page.rb
2 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/11/161411/1
diff --git a/tests/browser/features/step_definitions/moderation_steps.rb
b/tests/browser/features/step_definitions/moderation_steps.rb
index 6ed9133..5ecf4fb 100644
--- a/tests/browser/features/step_definitions/moderation_steps.rb
+++ b/tests/browser/features/step_definitions/moderation_steps.rb
@@ -25,6 +25,7 @@
end
When(/^I give reason for hiding as being "(.*?)"$/) do |arg1|
+ on(FlowPage).dialog_input_element.when_present.click
on(FlowPage).dialog_input_element.when_present.send_keys( arg1 )
end
diff --git a/tests/browser/features/support/pages/flow_page.rb
b/tests/browser/features/support/pages/flow_page.rb
index 38ae974..52c62fa 100644
--- a/tests/browser/features/support/pages/flow_page.rb
+++ b/tests/browser/features/support/pages/flow_page.rb
@@ -30,10 +30,11 @@
a(:topics_only_view, href: "#topics/topics")
# Dialogs
- div(:dialog, css: ".ui-dialog")
- textarea(:dialog_input, css: ".ui-dialog textarea")
- button(:dialog_cancel, css: ".ui-dialog .mw-ui-destructive")
- button(:dialog_submit, css: ".ui-dialog .mw-ui-constructive")
+ div(:dialog, css: ".flow-ui-modal")
+ # Is an input when not focused, textarea when focused
+ text_field(:dialog_input, css: ".flow-ui-modal .mw-ui-input")
+ button(:dialog_cancel, css: ".flow-ui-modal .mw-ui-destructive")
+ button(:dialog_submit, css: ".flow-ui-modal .mw-ui-constructive")
# Posts
## Highlighted post
--
To view, visit https://gerrit.wikimedia.org/r/161411
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a3e8db8246bb40af8e83bbafc6dc8d9120cecef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Spage <sp...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
