jenkins-bot has submitted this change and it was merged.
Change subject: Add tests for CentralAuthUser::getInstance()
......................................................................
Add tests for CentralAuthUser::getInstance()
Change-Id: I972fedd5ee6cb52e9d524f21b92287c18207883b
---
M tests/CentralAuthUserTest.php
1 file changed, 17 insertions(+), 0 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/CentralAuthUserTest.php b/tests/CentralAuthUserTest.php
index 8c5a426..98041cc 100644
--- a/tests/CentralAuthUserTest.php
+++ b/tests/CentralAuthUserTest.php
@@ -9,6 +9,23 @@
class CentralAuthUserTest extends MediaWikiTestCase {
/**
+ * @covers CentralAuthUser::getInstance
+ */
+ public function testGetInstance() {
+ $user = User::newFromName( 'FooBarBaz' );
+ unset( $user->centralAuthObj );
+ $caUser = CentralAuthUser::getInstance( $user );
+ $this->assertInstanceOf( 'CentralAuthUser', $caUser );
+ $this->assertEquals( $user->getName(), $caUser->getName() );
+ $this->assertSame( $user->centralAuthObj, $caUser );
+
+ // Now test it just reads from the cache, no matter what
+ $user2 = User::newFromName( 'BazBarFoo' );
+ $user2->centralAuthObj = 'blahblahblah';
+ $this->assertEquals( 'blahblahblah',
CentralAuthUser::getInstance( $user2 ) );
+ }
+
+ /**
* @covers CentralAuthUser::newUnattached
*/
public function testNewUnattached() {
--
To view, visit https://gerrit.wikimedia.org/r/161643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I972fedd5ee6cb52e9d524f21b92287c18207883b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
