jenkins-bot has submitted this change and it was merged.
Change subject: render.article: Correctly space extract for landscape images
with smaller heights
......................................................................
render.article: Correctly space extract for landscape images with smaller
heights
Change-Id: Ie781621366650fe4c5a0affcae564fa512fab65c
---
M resources/ext.popups.renderer.article.js
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
AndyRussG: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.popups.renderer.article.js
b/resources/ext.popups.renderer.article.js
index 972fa6a..c2c62d3 100644
--- a/resources/ext.popups.renderer.article.js
+++ b/resources/ext.popups.renderer.article.js
@@ -458,6 +458,13 @@
mw.popups.settings.open();
} );
+ if ( !flippedY && !tall && cache.settings.thumbnail.height <
article.SIZES.landscapeImage.h ) {
+ $( '.mwe-popups-extract').css(
+ 'margin-top',
+ cache.settings.thumbnail.height + 6
+ );
+ }
+
if ( !svg && flippedY && !tall ) {
$( '.mwe-popups-extract' ).css( 'margin-top', '206px' );
}
--
To view, visit https://gerrit.wikimedia.org/r/135779
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie781621366650fe4c5a0affcae564fa512fab65c
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
