Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/161979
Change subject: CE fixes
......................................................................
CE fixes
Change-Id: Ie51fb76e9a3fb2ed585271e45fa8ea779a59dff1
---
M src/ce/nodes/ve.ce.TableNode.js
M src/ce/styles/nodes/ve.ce.TableCellNode.css
M src/ce/styles/nodes/ve.ce.TableNode.css
3 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/79/161979/1
diff --git a/src/ce/nodes/ve.ce.TableNode.js b/src/ce/nodes/ve.ce.TableNode.js
index cc3d633..8a66937 100644
--- a/src/ce/nodes/ve.ce.TableNode.js
+++ b/src/ce/nodes/ve.ce.TableNode.js
@@ -18,7 +18,7 @@
ve.ce.BranchNode.call( this, model, config );
this.surface = null;
- this.focused = false;
+ this.active = false;
// A ve.dm.TableMatrix.Rectange instance or null if no valid selection
this.selectedRectangle = null;
};
@@ -82,7 +82,7 @@
var isSelected, tableSelection,
range = this.model.getRange();
- // Consider this table focused when the selection is fully within the
range
+ // Consider this table active when the selection is fully within the
range
isSelected = ( selection && range.containsRange( selection ) );
// make sure that the selection does really belong to this table not to
a nested one
@@ -91,16 +91,16 @@
isSelected = ( tableSelection && tableSelection.node ===
this.model );
}
- this.$element.toggleClass( 've-ce-tableNode-focused', isSelected );
+ this.$element.toggleClass( 've-ce-tableNode-active', isSelected );
if ( isSelected ) {
- if ( !this.focused ) {
- this.focused = true;
+ if ( !this.active ) {
+ this.active = true;
this.$overlay.show();
}
this.selectedRectangle = this.model.getRectangle(
tableSelection.startCell, tableSelection.endCell );
this.updateOverlayDebounced();
- } else if ( !isSelected && this.focused ) {
- this.focused = false;
+ } else if ( !isSelected && this.active ) {
+ this.active = false;
this.selectedRectangle = null;
this.$overlay.hide();
}
diff --git a/src/ce/styles/nodes/ve.ce.TableCellNode.css
b/src/ce/styles/nodes/ve.ce.TableCellNode.css
index 119dcea..d29da34 100644
--- a/src/ce/styles/nodes/ve.ce.TableCellNode.css
+++ b/src/ce/styles/nodes/ve.ce.TableCellNode.css
@@ -9,7 +9,7 @@
padding: 0.25em 0.5em;
}
-.ve-ce-tableNode-focused > tbody > tr > .ve-ce-tableCellNode {
+.ve-ce-tableNode-active > tbody > tr > .ve-ce-tableCellNode {
border-style: solid;
}
diff --git a/src/ce/styles/nodes/ve.ce.TableNode.css
b/src/ce/styles/nodes/ve.ce.TableNode.css
index 030cea0..b7972d5 100644
--- a/src/ce/styles/nodes/ve.ce.TableNode.css
+++ b/src/ce/styles/nodes/ve.ce.TableNode.css
@@ -14,7 +14,7 @@
pointer-events: none;
}
-.ve-ce-tableNode-focused > .ve-ce-tableNodeOverlay {
+.ve-ce-tableNode-active > .ve-ce-tableNodeOverlay {
visibility: visible;
}
--
To view, visit https://gerrit.wikimedia.org/r/161979
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie51fb76e9a3fb2ed585271e45fa8ea779a59dff1
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
