Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/162009
Change subject: Removed deprecated Job methods
......................................................................
Removed deprecated Job methods
Change-Id: Ib7a06ab19b31472c99cdccd418011beb6f075ca4
---
M includes/jobqueue/Job.php
1 file changed, 0 insertions(+), 68 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/09/162009/1
diff --git a/includes/jobqueue/Job.php b/includes/jobqueue/Job.php
index ee3f2c2..9211100 100644
--- a/includes/jobqueue/Job.php
+++ b/includes/jobqueue/Job.php
@@ -47,19 +47,11 @@
/** @var string Text for error that occurred last */
protected $error;
-
/*-------------------------------------------------------------------------
- * Abstract functions
-
*------------------------------------------------------------------------*/
-
/**
* Run the job
* @return bool Success
*/
abstract public function run();
-
-
/*-------------------------------------------------------------------------
- * Static functions
-
*------------------------------------------------------------------------*/
/**
* Create the appropriate object to handle a specific job
@@ -79,66 +71,6 @@
}
throw new MWException( "Invalid job command `{$command}`" );
}
-
- /**
- * Batch-insert a group of jobs into the queue.
- * This will be wrapped in a transaction with a forced commit.
- *
- * This may add duplicate at insert time, but they will be
- * removed later on, when the first one is popped.
- *
- * @param array $jobs Array of Job objects
- * @return bool
- * @deprecated since 1.21
- */
- public static function batchInsert( $jobs ) {
- JobQueueGroup::singleton()->push( $jobs );
- return true;
- }
-
- /**
- * Insert a group of jobs into the queue.
- *
- * Same as batchInsert() but does not commit and can thus
- * be rolled-back as part of a larger transaction. However,
- * large batches of jobs can cause slave lag.
- *
- * @param array $jobs Array of Job objects
- * @return bool
- * @deprecated since 1.21
- */
- public static function safeBatchInsert( $jobs ) {
- JobQueueGroup::singleton()->push( $jobs, JobQueue::QOS_ATOMIC );
- return true;
- }
-
- /**
- * Pop a job of a certain type. This tries less hard than pop() to
- * actually find a job; it may be adversely affected by concurrent job
- * runners.
- *
- * @param string $type
- * @return Job|bool Returns false if there are no jobs
- * @deprecated since 1.21
- */
- public static function pop_type( $type ) {
- return JobQueueGroup::singleton()->get( $type )->pop();
- }
-
- /**
- * Pop a job off the front of the queue.
- * This is subject to $wgJobTypesExcludedFromDefaultQueue.
- *
- * @return Job|bool False if there are no jobs
- * @deprecated since 1.21
- */
- public static function pop() {
- return JobQueueGroup::singleton()->pop();
- }
-
-
/*-------------------------------------------------------------------------
- * Non-static functions
-
*------------------------------------------------------------------------*/
/**
* @param string $command
--
To view, visit https://gerrit.wikimedia.org/r/162009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7a06ab19b31472c99cdccd418011beb6f075ca4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
