jenkins-bot has submitted this change and it was merged.
Change subject: QA: Test that hidden post's content isn't visible
......................................................................
QA: Test that hidden post's content isn't visible
Test checked that "marked as hidden" but did not check that content of
hidden post is hidden.
Also enable these tests on beta and test2, not sure why they weren't.
Also remove bogus comment about User_talk.
Test will fail until bug 71132 is fixed; such fix should merge or be
based off this.
Change-Id: I83a93b1fed53aac6c36ff70edfcdbb0678760233
---
M tests/browser/features/reply_moderation.feature
M tests/browser/features/step_definitions/reply_moderation_steps.rb
M tests/browser/features/support/pages/flow_page.rb
3 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/reply_moderation.feature
b/tests/browser/features/reply_moderation.feature
index 2bdc5bf..c52a595 100644
--- a/tests/browser/features/reply_moderation.feature
+++ b/tests/browser/features/reply_moderation.feature
@@ -1,7 +1,5 @@
-@chrome @firefox @internet_explorer_10 @login
+@chrome @en.wikipedia.beta.wmflabs.org @firefox @internet_explorer_10 @login
@test2.wikipedia.org
Feature: Reply moderation
-
- Assumes Flow is enabled for the User_talk namespace.
Background:
Given I am logged in
@@ -16,3 +14,4 @@
And I give reason for hiding as being "Shhhh!"
And I click the Hide button in the dialog
Then the 3rd comment should be marked as hidden
+ And the content of the 3rd comment should not be visible
diff --git a/tests/browser/features/step_definitions/reply_moderation_steps.rb
b/tests/browser/features/step_definitions/reply_moderation_steps.rb
index 18cc63f..bb92352 100644
--- a/tests/browser/features/step_definitions/reply_moderation_steps.rb
+++ b/tests/browser/features/step_definitions/reply_moderation_steps.rb
@@ -11,3 +11,7 @@
on(FlowPage).third_reply_element.class_name.should match
/flow-post-moderated/
on(FlowPage).third_reply_moderation_msg.should match( 'This comment was
hidden' )
end
+
+Then (/^the content of the 3rd comment should not be visible$/) do
+ on(FlowPage).third_reply_content_element.should_not be_visible
+end
diff --git a/tests/browser/features/support/pages/flow_page.rb
b/tests/browser/features/support/pages/flow_page.rb
index 3667165..c971ecb 100644
--- a/tests/browser/features/support/pages/flow_page.rb
+++ b/tests/browser/features/support/pages/flow_page.rb
@@ -174,6 +174,9 @@
div(:third_reply_moderation_msg) do |page|
page.third_reply_element.div_element(css: '.flow-moderated-post-content',
index: 0)
end
+ div(:third_reply_content) do |page|
+ page.third_reply_element.div_element(css: '.flow-post-content', index: 0)
+ end
a(:third_post_actions_link, css: ".flow-topic .flow-post .flow-menu-js-drop
a", index: 3)
ul(:third_post_actions_menu, css: ".flow-topic .flow-post .flow-menu ul",
index: 3)
--
To view, visit https://gerrit.wikimedia.org/r/162027
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83a93b1fed53aac6c36ff70edfcdbb0678760233
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
