Florianschmidtwelzow has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/162295

Change subject: Make sure, issues only added once
......................................................................

Make sure, issues only added once

If there are nested tables in the issues related content, they
will be added twice (or more times, if there are nested tables
in nested tables). Make sure, that only content will be added
if we have the "clear", extracted message.

Bug: 71046
Change-Id: I9bb78e413487c24c7c1a1090b15d4146279e2b89
---
M javascripts/modules/issues/issues.js
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/95/162295/1

diff --git a/javascripts/modules/issues/issues.js 
b/javascripts/modules/issues/issues.js
index 6d1707d..cfe3596 100644
--- a/javascripts/modules/issues/issues.js
+++ b/javascripts/modules/issues/issues.js
@@ -13,14 +13,14 @@
                        var contents,
                                $this = $( this );
                        if ( $this.find( selector ).length ) {
-                               contents = extractMessage( $this );
+                               extractMessage( $this );
                        } else {
                                // Clean up talk page boxes
                                $this.find( 'table, .noprint' ).remove();
                                contents = $this.html();
-                       }
-                       if ( contents ) {
-                               $( '<p>' ).html( contents ).appendTo( 
$container );
+                               if ( contents ) {
+                                       $( '<p>' ).html( contents ).appendTo( 
$container );
+                               }
                        }
                } );
                return $container.html();

-- 
To view, visit https://gerrit.wikimedia.org/r/162295
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9bb78e413487c24c7c1a1090b15d4146279e2b89
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to