Dan-nl has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/162825

Change subject: Updated cURL constants array
......................................................................

Updated cURL constants array

the mediawiki-core-regression-hhvm-master test for I21747063 found
failures for some constants provided by the provideCurlConstants()
array.

https://integration.wikimedia.org/ci/job/mediawiki-core-regression-hhvm-master/2072/console

i cross-checked the failed constants with the php manual
http://php.net/manual/en/curl.constants.php and removed the
constants not listed in the php manual.

there are still some failures, but those constants are listed in
the php manual, so i left them in the provided array.

Change-Id: I30c5e78eacf19071aaf44834ca188172f082e161
---
M tests/phpunit/includes/HttpTest.php
1 file changed, 0 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/25/162825/1

diff --git a/tests/phpunit/includes/HttpTest.php 
b/tests/phpunit/includes/HttpTest.php
index 59ffb90..27e8b5f 100644
--- a/tests/phpunit/includes/HttpTest.php
+++ b/tests/phpunit/includes/HttpTest.php
@@ -414,21 +414,7 @@
                        array( 'CURLOPT_VERBOSE' ),
                        array( 'CURLOPT_WRITEFUNCTION' ),
                        array( 'CURLOPT_WRITEHEADER' ),
-                       array( 'CURLPROTO_ALL' ),
-                       array( 'CURLPROTO_DICT' ),
-                       array( 'CURLPROTO_FILE' ),
-                       array( 'CURLPROTO_FTP' ),
-                       array( 'CURLPROTO_FTPS' ),
-                       array( 'CURLPROTO_HTTP' ),
-                       array( 'CURLPROTO_HTTPS' ),
-                       array( 'CURLPROTO_LDAP' ),
-                       array( 'CURLPROTO_LDAPS' ),
-                       array( 'CURLPROTO_SCP' ),
-                       array( 'CURLPROTO_SFTP' ),
-                       array( 'CURLPROTO_TELNET' ),
-                       array( 'CURLPROTO_TFTP' ),
                        array( 'CURLPROXY_HTTP' ),
-                       array( 'CURLPROXY_SOCKS4' ),
                        array( 'CURLPROXY_SOCKS5' ),
                        array( 'CURLSSH_AUTH_DEFAULT' ),
                        array( 'CURLSSH_AUTH_HOST' ),

-- 
To view, visit https://gerrit.wikimedia.org/r/162825
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I30c5e78eacf19071aaf44834ca188172f082e161
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Dan-nl <d_ent...@yahoo.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to