Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/162839
Change subject: HHVM: update JIT settings ...................................................................... HHVM: update JIT settings * Update configuration key names for <https://github.com/facebook/hhvm/commit/ca99ef1>. * Keep the ratio of a_size, a_cold, and a_frozen to have a ratio of 1 : 0.33 : 1, per Brett's advice. Change-Id: I192efa726a76bcc799490a164cf9bed0e56d5552 --- M modules/hhvm/manifests/init.pp 1 file changed, 27 insertions(+), 19 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/39/162839/1 diff --git a/modules/hhvm/manifests/init.pp b/modules/hhvm/manifests/init.pp index d3c29f9..96c154a 100644 --- a/modules/hhvm/manifests/init.pp +++ b/modules/hhvm/manifests/init.pp @@ -81,6 +81,25 @@ ## Settings + ### JIT + + # HHVM's translation cache is a slab of memory allocated in the + # bottom 2 GiB for caching translated code. It is partitioned into + # several differently-sized blocks of memory that group code blocks + # by frequency of execution. + # + # You can check TC memory usage stats via the /vm-tcspace end-point + # of the admin server. + # + # A ratio of 1 : 0.33 : 1 for a : a_cold : a_frozen is good general + # guidance. + + $base_jit_size = to_bytes('100 Mb') + $a_size = $base_jit_size + $a_cold_size = 0.33 * $base_jit_size + $a_frozen_size = $base_jit_size + + $common_defaults = { date => { timezone => 'UTC' }, hhvm => { @@ -106,28 +125,17 @@ }, } + $fcgi_defaults = { memory_limit => '300M', hhvm => { - jit => true, - - # HHVM's translation cache is a slab of memory allocated in the - # bottom 2 GiB for caching translated code. It is partitioned into - # several differently-sized blocks of memory that group code blocks - # by frequency of execution. - # - # You can check TC memory usage stats via the /vm-tcspace end-point - # of the admin server. - # - # XXX: These configuration options have been renamed in - # <https://github.com/facebook/hhvm/commit/ca99ef1>. - - jit_afrozen_size => to_bytes('100 Mb'), - jit_acold_size => to_bytes('60 Mb'), - - repo => { central => { path => '/run/hhvm/cache/fcgi.hhbc.sq3' } }, - admin_server => { port => 9001 }, - server => { + jit => true, + jit_a_size => $a_size, + jit_a_cold_size => $a_cold_size, + jit_a_frozen_size => $a_frozen_size, + repo => { central => { path => '/run/hhvm/cache/fcgi.hhbc.sq3' } }, + admin_server => { port => 9001 }, + server => { port => 9000, type => 'fastcgi', gzip_compression_level => 0, -- To view, visit https://gerrit.wikimedia.org/r/162839 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I192efa726a76bcc799490a164cf9bed0e56d5552 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ori.livneh <o...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits