Arlolra has uploaded a new change for review.
https://gerrit.wikimedia.org/r/163064
Change subject: Debug: Get crashing err txt from stderr
......................................................................
Debug: Get crashing err txt from stderr
Change-Id: I350ec6c4d88315f1b65112a7aa6430277fbfa392
---
M lib/threads/backend.js
1 file changed, 8 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection/OfflineContentGenerator
refs/changes/64/163064/1
diff --git a/lib/threads/backend.js b/lib/threads/backend.js
index 8ff5e94..fc8ed0d 100644
--- a/lib/threads/backend.js
+++ b/lib/threads/backend.js
@@ -503,7 +503,7 @@
config.backend.writers[writer].additionalArgs || [],
bundleFile
)
- );
+ , { silent: true });
child.on( 'error', function ( err ) {
if ( killTimer ) {
@@ -516,6 +516,12 @@
child.on( 'message', function ( message, handle ) {
processReceivedMessage( message, jobDetails, 'renderer' );
} );
+
+ var errData = "";
+ child.stderr.on('data', function(data) {
+ errData += data;
+ });
+
child.on( 'exit', function ( code, signal ) {
if ( killTimer ) {
clearTimeout( killTimer );
@@ -530,7 +536,7 @@
if ( signal === 'SIGTERM' ) {
p.reject( new BundlerError( 'Killed renderer,
exceeded execution time limit' ) );
} else {
- p.reject( new BundlerError( 'Rendering process
died with non zero code: '+code ) );
+ p.reject( new BundlerError( errData ||
'Rendering process died with non zero code: '+code ) );
}
} else {
Promise.promisify( fs.stat )( renderFile )
--
To view, visit https://gerrit.wikimedia.org/r/163064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I350ec6c4d88315f1b65112a7aa6430277fbfa392
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection/OfflineContentGenerator
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
