jenkins-bot has submitted this change and it was merged.
Change subject: buttons: Set min-width of button groups and icon buttons
......................................................................
buttons: Set min-width of button groups and icon buttons
This was initially changed to 80px in
I8e6beaf12d7cf1f1af20f4ff144eb0a7c2667a47
and then to 70px because 80px was too large for mobile in
I00b44508e7783957a8c24c4890cc1ba4dfe265da
Buttons inside button groups and icon buttons have a requirement
of being narrower than that but not narrower than their height.
When pseudo element css is not supported icons need a min-width
Bug: 71248
Change-Id: Icf45b9c8800067d3e30f23bbda4a6de21b1289d1
---
M resources/src/mediawiki.ui/components/buttons.less
M resources/src/mediawiki.ui/components/icons.less
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.ui/components/buttons.less
b/resources/src/mediawiki.ui/components/buttons.less
index 3d60b7a..01c481d 100644
--- a/resources/src/mediawiki.ui/components/buttons.less
+++ b/resources/src/mediawiki.ui/components/buttons.less
@@ -257,6 +257,7 @@
//
// Styleguide 2.2.
.mw-ui-button-group > * {
+ min-width: 48px;
border-radius: 0;
float: left;
diff --git a/resources/src/mediawiki.ui/components/icons.less
b/resources/src/mediawiki.ui/components/icons.less
index 3a92b21..bf8e41e 100644
--- a/resources/src/mediawiki.ui/components/icons.less
+++ b/resources/src/mediawiki.ui/components/icons.less
@@ -23,6 +23,7 @@
.mw-ui-icon {
position: relative;
min-height: @iconSize;
+ min-width: @iconSize;
// Standalone icons
//
--
To view, visit https://gerrit.wikimedia.org/r/162771
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf45b9c8800067d3e30f23bbda4a6de21b1289d1
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
