jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: WikiDataApi::getClaims
......................................................................
Hygiene: WikiDataApi::getClaims
Change-Id: Ibee6fc573610da14d149add893b87d5ca459111c
---
M javascripts/modules/wikigrok/WikiDataApi.js
M javascripts/modules/wikigrok/WikiGrokDialog.js
M javascripts/modules/wikigrok/wikigrokeval.js
3 files changed, 24 insertions(+), 23 deletions(-)
Approvals:
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/wikigrok/WikiDataApi.js
b/javascripts/modules/wikigrok/WikiDataApi.js
index 18280b0..6874e61 100644
--- a/javascripts/modules/wikigrok/WikiDataApi.js
+++ b/javascripts/modules/wikigrok/WikiDataApi.js
@@ -7,18 +7,29 @@
WikiDataApi = Api.extend( {
apiUrl: 'https://www.wikidata.org/w/api.php',
- initialize: function() {
+ initialize: function( options ) {
+ this.itemId = options.itemId;
Api.prototype.initialize.apply( this, arguments );
+ },
+ ajax: function( data, options ) {
+ options = options || {};
+ options.url = this.apiUrl;
+ options.dataType = 'jsonp';
+ return Api.prototype.ajax.call( this, data, options );
+ },
+ getClaims: function() {
+ return this.ajax( {
+ action: 'wbgetentities',
+ ids: this.itemId,
+ props: 'claims',
+ format: 'json'
+ } );
},
getOccupations: function( occupationId ) {
return this.ajax( {
action: 'wbgetentities',
props: 'labels',
ids: occupationId
- },
- {
- url: this.apiUrl,
- dataType: 'jsonp'
} );
}
} );
diff --git a/javascripts/modules/wikigrok/WikiGrokDialog.js
b/javascripts/modules/wikigrok/WikiGrokDialog.js
index 30cefd1..727d1ca 100644
--- a/javascripts/modules/wikigrok/WikiGrokDialog.js
+++ b/javascripts/modules/wikigrok/WikiGrokDialog.js
@@ -37,7 +37,7 @@
initialize: function( options ) {
this.apiWikiGrok = new WikiGrokApi( { itemId:
options.itemId } );
- this.apiWikiData = new WikiDataApi();
+ this.apiWikiData = new WikiDataApi( { itemId:
options.itemId } );
Panel.prototype.initialize.apply( this, arguments );
},
diff --git a/javascripts/modules/wikigrok/wikigrokeval.js
b/javascripts/modules/wikigrok/wikigrokeval.js
index e4460a3..c2979bb 100644
--- a/javascripts/modules/wikigrok/wikigrokeval.js
+++ b/javascripts/modules/wikigrok/wikigrokeval.js
@@ -1,25 +1,15 @@
( function( M, $ ) {
- var wikidataID = mw.config.get( 'wgWikibaseItemId' ),
+ var api,
+ wikidataID = mw.config.get( 'wgWikibaseItemId' ),
+ WikiDataApi = M.require( 'modules/wikigrok/WikiDataApi' ),
WikiGrokDialog = M.require( 'modules/wikigrok/WikiGrokDialog' );
// Get existing Wikidata claims about this page so we can decide if
it's appropriate
// to display the WikiGrok interface.
if ( !M.settings.getUserSetting( 'mfHideWikiGrok' ) ) {
- $.ajax( {
- type: 'get',
- url: 'https://www.wikidata.org/w/api.php',
- data: {
- 'action': 'wbgetentities',
- 'ids': wikidataID,
- 'props': 'claims',
- 'format': 'json'
- },
- // Using JSONP so we aren't restricted by cross-site
rules. This isn't
- // strictly needed on the Wikimedia cluster since it
has CORS exceptions
- // for requests from other Wikimedia sites, but this
makes it easy to
- // test locally.
- dataType: 'jsonp',
- success: function( data ) {
+ api = new WikiDataApi( { itemId: wikidataID });
+ api.getClaims().done(
+ function( data ) {
var instanceClaims,
loadWikiGrokDialog = false;
@@ -42,7 +32,7 @@
}
}
}
- } );
+ );
}
}( mw.mobileFrontend, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/162185
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibee6fc573610da14d149add893b87d5ca459111c
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
