Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/163626
Change subject: Test for string in Pbkdf2Password::crypt()
......................................................................
Test for string in Pbkdf2Password::crypt()
The fatal in HHVM isn't giving us a stack trace, so throw an exception
to get one.
Bug: 71421
Change-Id: I3b0a1de69cdcf6bc3ebad8ebc472874919c290a6
---
M includes/password/Pbkdf2Password.php
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/26/163626/1
diff --git a/includes/password/Pbkdf2Password.php
b/includes/password/Pbkdf2Password.php
index 080e3b0..8c05728 100644
--- a/includes/password/Pbkdf2Password.php
+++ b/includes/password/Pbkdf2Password.php
@@ -47,6 +47,9 @@
}
if ( function_exists( 'hash_pbkdf2' ) ) {
+ if ( !is_string( $password ) ) {
+ throw new MWException( __METHOD__ . ':
$password is not a string' );
+ }
$hash = hash_pbkdf2(
$this->params['algo'],
$password,
--
To view, visit https://gerrit.wikimedia.org/r/163626
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b0a1de69cdcf6bc3ebad8ebc472874919c290a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.24wmf22
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
