Amire80 has uploaded a new change for review. https://gerrit.wikimedia.org/r/164757
Change subject: Make descriptionview match the appropriate language direction ...................................................................... Make descriptionview match the appropriate language direction Change-Id: Ic8e8a1fb0fd0ddcdd5a740248618d756856cdae9 --- M lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js 1 file changed, 12 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/57/164757/1 diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js b/lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js index 51d098a..2d7067d 100644 --- a/lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js +++ b/lib/resources/jquery.wikibase/jquery.wikibase.descriptionview.js @@ -126,12 +126,19 @@ var self = this; + var dir = ( $.uls && $.uls.data ) ? + $.uls.data.getDir( this.options.value.language ) : + $( 'html' ).prop( 'dir' ); + var $input = $( '<input/>' ) - // TODO: Inject correct placeholder via options - .attr( 'placeholder', mw.msg( - 'wikibase-description-edit-placeholder-language-aware', - wb.getLanguageNameByCode( this.options.value.language ) - ) ) + .attr( { + // TODO: Inject correct placeholder via options + placeholder: mw.msg( + 'wikibase-description-edit-placeholder-language-aware', + wb.getLanguageNameByCode( this.options.value.language ) + ), + dir: dir + }) .on( 'eachchange.' + this.widgetName, function( event ) { self._trigger( 'change' ); } ); -- To view, visit https://gerrit.wikimedia.org/r/164757 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic8e8a1fb0fd0ddcdd5a740248618d756856cdae9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits