Hello Ottomata,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/164762
to review the following change.
Change subject: Declare namenode directory only once
......................................................................
Declare namenode directory only once
The namenode's base directory was declared in both
/etc/puppet/manifests/role/analytics/hadoop.pp:280
/etc/puppet/modules/cdh/manifests/hadoop/namenode.pp:36
which made puppet fail with “Duplicate declaration”. We drop the
role's definition of it, as the directory is only needed on namenodes
anyways.
Change-Id: I8a5a6de00731af2dadb8ab2b3d36ad43faf2f49c
---
M manifests/role/analytics/hadoop.pp
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/62/164762/1
diff --git a/manifests/role/analytics/hadoop.pp
b/manifests/role/analytics/hadoop.pp
index eed172f..ea3baa1 100644
--- a/manifests/role/analytics/hadoop.pp
+++ b/manifests/role/analytics/hadoop.pp
@@ -271,7 +271,6 @@
# below, I just create them here.
file { [
$hadoop_var_directory,
- $hadoop_name_directory,
$hadoop_journal_directory,
$hadoop_data_directory,
$datanode_mounts,
--
To view, visit https://gerrit.wikimedia.org/r/164762
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a5a6de00731af2dadb8ab2b3d36ad43faf2f49c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: QChris <christ...@quelltextlich.at>
Gerrit-Reviewer: Ottomata <o...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
