Hello Ottomata,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/165395
to review the following change.
Change subject: [webstatscollector] Add '[uU]ndefined' condition
......................................................................
[webstatscollector] Add '[uU]ndefined' condition
Requests to 'undefined' and 'Undefined' get excluded as they seem to
stem from JavaScript glitches for the by far bigger part.
Bug: 66352
Change-Id: I4fd0d15e1e5ae50a6b51c0e58821f1edc98d3ed8
---
M pageviews/webstatscollector/pageview_definition.dot
M pageviews/webstatscollector/pageview_definition.png
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/metrics
refs/changes/95/165395/1
diff --git a/pageviews/webstatscollector/pageview_definition.dot
b/pageviews/webstatscollector/pageview_definition.dot
index 9f75abf..fd5a3dc 100644
--- a/pageviews/webstatscollector/pageview_definition.dot
+++ b/pageviews/webstatscollector/pageview_definition.dot
@@ -34,6 +34,7 @@
decision_has_path [label="url has path", style=filled,
color="Gold"];
decision_has_wiki [label="path starts in '/wiki'", style=filled,
color="Gold"];
decision_centralautologin [label="path starts in
'/wiki/Special:CentralAutoLogin/'", style=filled, color="Gold"];
+ decision_undefined [label="path is either '/wiki/undefined' or
'/wiki/Undefined'", style=filled, color="Gold"];
decision_has_language_n_proj [label="url has language and project",
style=filled, color="Gold"];
decision_wikimedia_project [label="is wikimedia project", style=filled,
color="Gold"];
decision_sub_project [label=<
@@ -76,9 +77,12 @@
decision_has_wiki -> decision_centralautologin [ label="yes"];
decision_has_wiki -> discard [ label="no"];
- decision_centralautologin -> decision_has_language_n_proj [ label="no"];
+ decision_centralautologin -> decision_undefined [ label="no"];
decision_centralautologin -> discard [ label="yes"];
+ decision_undefined -> decision_has_language_n_proj [ label="no"];
+ decision_undefined -> discard [ label="yes"];
+
decision_has_language_n_proj -> decision_wikimedia_project [ label="yes"];
decision_has_language_n_proj -> discard [ label="no"];
diff --git a/pageviews/webstatscollector/pageview_definition.png
b/pageviews/webstatscollector/pageview_definition.png
index 92503e5..8f8e8b4 100644
--- a/pageviews/webstatscollector/pageview_definition.png
+++ b/pageviews/webstatscollector/pageview_definition.png
Binary files differ
--
To view, visit https://gerrit.wikimedia.org/r/165395
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4fd0d15e1e5ae50a6b51c0e58821f1edc98d3ed8
Gerrit-PatchSet: 1
Gerrit-Project: analytics/metrics
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
