[MediaWiki-commits] [Gerrit] Changed magic word to § symbol for project naming convention - change (phabricator...Sprint)

[Christopher Johnson (WMDE) (Code Review)]

Christopher Johnson (WMDE) has submitted this change and it was merged.

Change subject: Changed magic word to § symbol for project naming convention
......................................................................


Changed magic word to § symbol for project naming convention

Change-Id: I6eaabc86fd3eafce59428a42001997d1c723b882
---
M src/BurndownActionMenuEventListener.php
M src/BurndownListController.php
M src/SprintProjectCustomField.php
3 files changed, 5 insertions(+), 6 deletions(-)

Approvals:
  Christopher Johnson (WMDE): Verified; Looks good to me, approved



diff --git a/src/BurndownActionMenuEventListener.php 
b/src/BurndownActionMenuEventListener.php
index 1422171..e197fa5 100644
--- a/src/BurndownActionMenuEventListener.php
+++ b/src/BurndownActionMenuEventListener.php
@@ -23,7 +23,7 @@
 
     $actions = null;
     if ($object instanceof PhabricatorProject &&
-      stripos($object->getName(), 'sprint') !== false) {
+      stripos($object->getName(), '§') !== false) {
       $actions = $this->renderUserItems($event);
     }
 
diff --git a/src/BurndownListController.php b/src/BurndownListController.php
index e5cfb43..50bc006 100644
--- a/src/BurndownListController.php
+++ b/src/BurndownListController.php
@@ -24,11 +24,10 @@
 
     $this->view = $nav->selectFilter($this->view, 'project');
 
-
-    // Load all projects with "Sprint" in the name.
+    // Load all projects with "§" in the name.
     $projects = id(new PhabricatorProjectQuery())
       ->setViewer($viewer)
-      ->withDatasourceQuery('sprint')
+      ->withDatasourceQuery('§')
       ->execute();
 
     $rows = array();
@@ -82,7 +81,7 @@
     $help = id(new PHUIBoxView())
       ->appendChild(phutil_tag('p', array(),
           "To have a project show up in this list, make sure it's name 
includes"
-          ."\"sprint\" and then edit it to set the start and end date."
+          ."\"§\" and then edit it to set the start and end date."
       ))
       ->addMargin(PHUI::MARGIN_LARGE);
 
diff --git a/src/SprintProjectCustomField.php b/src/SprintProjectCustomField.php
index 86b7681..552f5ec 100644
--- a/src/SprintProjectCustomField.php
+++ b/src/SprintProjectCustomField.php
@@ -22,7 +22,7 @@
    */
   protected function shouldShowSprintFields()
   {
-    return (strpos($this->getObject()->getName(),'Sprint') !== FALSE);
+    return (strpos($this->getObject()->getName(),'§') !== FALSE);
   }
 
   /**

-- 
To view, visit https://gerrit.wikimedia.org/r/165505
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6eaabc86fd3eafce59428a42001997d1c723b882
Gerrit-PatchSet: 2
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <christopher.john...@wikimedia.de>
Gerrit-Reviewer: Christopher Johnson (WMDE) <christopher.john...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits