Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165592
Change subject: Followup b8d8a5b: pass selections, not ranges, to
SurfaceFragment#clone
......................................................................
Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone
Bug: 71825
Change-Id: I095d20840a1844f557a023f933aa1e6104138002
---
M modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js
M modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/92/165592/1
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js
index 29ce62a..98cdb66 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js
@@ -192,7 +192,9 @@
// initialized the
internal node with a paragraph - getting the range of the
// item covers the
entire paragraph so we have to get the range of it's
// first (and empty)
child
-
this.getFragment().clone( item.getChildren()[0].getRange() )
+
this.getFragment().clone(
+ new
ve.dm.LinearSelection( doc, item.getChildren()[0].getRange() )
+ )
);
}
}
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
index 9027633..bb6dee0 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
@@ -972,7 +972,7 @@
if ( this.selectedNode ) {
// Remove the old image
this.fragment =
this.getFragment().clone(
-
this.selectedNode.getOuterRange()
+ new
ve.dm.LinearSelection( this.fragment.getDocument(),
this.selectedNode.getOuterRange() )
);
this.fragment.removeContent();
}
--
To view, visit https://gerrit.wikimedia.org/r/165592
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I095d20840a1844f557a023f933aa1e6104138002
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
