jenkins-bot has submitted this change and it was merged.
Change subject: Followup b8d8a5b: pass selections, not ranges, to
SurfaceFragment#clone
......................................................................
Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone
Bug: 71825
Change-Id: Iaa15f2fac0a74cce15e7ac3496a34012896eec96
---
M src/ui/inspectors/ve.ui.CommentInspector.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/inspectors/ve.ui.CommentInspector.js
b/src/ui/inspectors/ve.ui.CommentInspector.js
index 499a75e..9d2d558 100644
--- a/src/ui/inspectors/ve.ui.CommentInspector.js
+++ b/src/ui/inspectors/ve.ui.CommentInspector.js
@@ -135,7 +135,9 @@
if ( this.commentNode ) {
if ( data.action === 'remove' || innerText ===
'' ) {
// Remove comment node
- this.fragment =
this.getFragment().clone( this.commentNode.getOuterRange() );
+ this.fragment =
this.getFragment().clone(
+ new ve.dm.LinearSelection(
this.fragment.getDocument(), this.commentNode.getOuterRange() )
+ );
this.fragment.removeContent();
} else {
// Edit comment node
--
To view, visit https://gerrit.wikimedia.org/r/165593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa15f2fac0a74cce15e7ac3496a34012896eec96
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
