jenkins-bot has submitted this change and it was merged.
Change subject: Only clear the page name if none is supplied
......................................................................
Only clear the page name if none is supplied
* Fixes a bug introduced in 88bb69e21f91a8570627f3aa801edb25e9f472d3
caught by our rt use.
Change-Id: I54e85918ab9334d10d7eab87c6fd3b417b78c89f
---
M api/routes.js
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/api/routes.js b/api/routes.js
index 44bd4fc..07046f3 100644
--- a/api/routes.js
+++ b/api/routes.js
@@ -238,6 +238,10 @@
function parseWt() {
env.log('info', 'started parsing');
+ if ( !res.local('pageName') ) {
+ // clear default page name
+ env.page.name = '';
+ }
return new Promise(function( resolve, reject ) {
var parser =
env.pipelineFactory.getPipeline('text/x-mediawiki/full');
parser.once('document', function( doc ) {
@@ -293,8 +297,6 @@
var p;
if ( wt && (!res.local('pageName') || !oldid) ) {
- // clear default page name
- env.page.name = '';
// don't fetch the page source
env.setPageSrcInfo( wt );
p = Promise.resolve();
--
To view, visit https://gerrit.wikimedia.org/r/165611
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54e85918ab9334d10d7eab87c6fd3b417b78c89f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Marcoil <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits