Hello Ottomata,

I'd like you to do a code review.  Please visit

    https://gerrit.wikimedia.org/r/165621

to review the following change.

Change subject: Drop unneeded dependencies from rules
......................................................................

Drop unneeded dependencies from rules

Change-Id: I2f955bb1e45d65127fdc3bcbe78a8638207f6d49
---
M Makefile
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/webstatscollector 
refs/changes/21/165621/1

diff --git a/Makefile b/Makefile
index c3a66ea..11e3376 100644
--- a/Makefile
+++ b/Makefile
@@ -16,13 +16,13 @@
 
 all: collector filter
 
-collector: collector.h collector.c export.c export.o
+collector: collector.h collector.c export.o
        gcc -o collector collector.c export.o -ldb -lpthread
 
 filter: filter.c
        gcc -o filter filter.c
 
-export.o: export.c collector.h collector.c filter.c
+export.o: export.c collector.h
        gcc -c -o export.o export.c
 
 clean:

-- 
To view, visit https://gerrit.wikimedia.org/r/165621
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f955bb1e45d65127fdc3bcbe78a8638207f6d49
Gerrit-PatchSet: 1
Gerrit-Project: analytics/webstatscollector
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to