Hello Ottomata,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/165622
to review the following change.
Change subject: Use GNU Make's implicit rules to build object and executable
files
......................................................................
Use GNU Make's implicit rules to build object and executable files
Thereby, CFLAGS, LDFLAGS and all the other environment variables get
actually used.
We drop -g from default CFLAGS, as debugging information are not
needed in a release.
Change-Id: I9409458ee75872fb6eb884ed866c7b2c5a122050
---
M Makefile
1 file changed, 4 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/webstatscollector
refs/changes/22/165622/1
diff --git a/Makefile b/Makefile
index 11e3376..17c332a 100644
--- a/Makefile
+++ b/Makefile
@@ -8,7 +8,10 @@
LDLIBS+=-ldb -lpthread
-CFLAGS+=-Wall -g
+CFLAGS+=-Wall
+# To get debug information into the executables, uncomment the
+# following line
+#CFLAGS+=-g
SUBDIRS=tests
@@ -17,13 +20,8 @@
all: collector filter
collector: collector.h collector.c export.o
- gcc -o collector collector.c export.o -ldb -lpthread
-
-filter: filter.c
- gcc -o filter filter.c
export.o: export.c collector.h
- gcc -c -o export.o export.c
clean:
$(RM) *.o collector filter
--
To view, visit https://gerrit.wikimedia.org/r/165622
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9409458ee75872fb6eb884ed866c7b2c5a122050
Gerrit-PatchSet: 1
Gerrit-Project: analytics/webstatscollector
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
