Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/165694
Change subject: Revert partially: "Show talk button only when JS enabled or
talk page not empty"
......................................................................
Revert partially: "Show talk button only when JS enabled or talk page not empty"
This reverts the part of I4311e23c6796548c91ace799ce66fb6d38242e17 to hide the
talk
button in stable mode. In alpha the talk button is still hidden when no JS or 0
discussions on it.
Bug: 71570
Change-Id: I15ddbe7c85a30605572d906d66b955f2ef390718
---
M includes/skins/SkinMinerva.php
M includes/skins/SkinMinervaAlpha.php
2 files changed, 2 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/94/165694/1
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index d982064..6e5a45e 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -710,14 +710,7 @@
}
if ( isset( $menu['talk'] ) ) {
- // It's only possible for a user to create a
new talk page if they have
- // Javascript, so if the talk page hasn't been
created yet, add a 'hidden'
- // CSS class which will be removed later via
Javascript.
- if ( $menu['talk']['class'] === 'new' ) {
- $menu['talk']['class'] = 'hidden icon
icon-32px icon-talk';
- } else {
- $menu['talk']['class'] = 'icon
icon-32px icon-talk';
- }
+ $menu['talk']['class'] = 'icon icon-32px
icon-talk';
if ( isset( $tpl->data['_talkdata'] ) ) {
$menu['talk']['text'] =
$tpl->data['_talkdata']['text'];
$menu['talk']['class'] =
$tpl->data['_talkdata']['class'];
diff --git a/includes/skins/SkinMinervaAlpha.php
b/includes/skins/SkinMinervaAlpha.php
index 334e2c9..5cee585 100644
--- a/includes/skins/SkinMinervaAlpha.php
+++ b/includes/skins/SkinMinervaAlpha.php
@@ -73,6 +73,7 @@
$talkLabel = wfMessage(
'mobile-frontend-talk-overlay-header' );
// add hidden css class to hide talk button,
when no content there. Adding content
// isn't possible without JS, so remove the
class in talk.js
+ // FIXME: What, if the talk page uses Flow
(appears as new and don't run talk.js, so it will be hidden with JS enabled)
$class = 'hidden icon icon-32px icon-talk';
}
$menu = $tpl->data['page_actions'];
--
To view, visit https://gerrit.wikimedia.org/r/165694
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15ddbe7c85a30605572d906d66b955f2ef390718
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
